From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD2A8C74A5B for ; Sun, 26 Mar 2023 18:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6VAY6rqX0a7NuZ8mXWVeYCuaa2QgePtygkkWM8ON5VM=; b=O+RkGYv2qaJJdP A31chbv9sfcirDKOgQs094KSvrx9ssDPlyXVNdlfLfwGwa7WG/lnwazM8gEWe51D2FsLK2bJV4Lja ymKSncG9MBOOUQ0Ie3CYfbqXNszpnVXu2OLnRZ64EqNO644tA8D0/m5QhjgXk6tabXrjGbl85zIp+ Pr4d0ZEEudSoD3P/EsFRKXFFVO2yIuA+v4WSnEkVyLZxgCbgai/HSs1f78bHIhl8nVYRh/CHLGT7K gscjyBMZNMqtK79r+YbX8zE78AaoUA2NAe/YaJFdpiY3JEAbhgEoHuE79g3TpJXwjNRurzUhPtA6A 2AhKjrnxKPvBtQRHdf7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgUxg-008yXW-2I; Sun, 26 Mar 2023 18:19:24 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgUxd-008yVD-2v for linux-arm-kernel@lists.infradead.org; Sun, 26 Mar 2023 18:19:23 +0000 Received: by mail-ed1-x534.google.com with SMTP id ew6so27026886edb.7 for ; Sun, 26 Mar 2023 11:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679854758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iRsdmVEmkxcp3g4ZbMN6Afce7+HfUPfqF6kGvf5nBhg=; b=Ys/WIc2tT3SpQOxjP2ekhZiOsQc1XgzldyHwX8iBX3A0TrIxjtvW6Ky9thPOlY1b8w YAIbiVjo4nbHjicHsETpZB4kTTSN4229zKctq4cuv64rjmIIQRoFjEZ3f0YQgWAyNdNC keURJRgEvdYeWWbooqBuVipAjeajDFt1Pvrm1E4GRFNjWXzE0lOcuqye+57Gz6+bIjyU oGUHIVSMuMHnv01ikTWLF2gasvQPacKlnmHIumJ/2C11GnwdxUSrmTw0cMjkhDLHuhKF qmfJSJbvr6/o1plGsIYuqamXCUj569zCCk9c9nzh1fi/Kb9Jsrb7ZalPMJbM2et5VAQr WV5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679854758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iRsdmVEmkxcp3g4ZbMN6Afce7+HfUPfqF6kGvf5nBhg=; b=6+h8OQl6LkNS5wNIytTCDfaNdjvTyH1+EjeCOOWpR+WceYGKYjLaXvfH1Ln6b1AIKd h9gawax5wMmhuCR5tlvcfnXb9UIEfdpzZHWyal5D8YU8G+fN8f5Qykxvc3FCGcV5/XPn MPOEXV+BASUMdsbGvsVsqghW2L8hk0bloo7SgrRK7q3LKkF2YDW2K/iB8BSaK8oSKFFx y1h/NK9MzD+W6eiBCZ54DY1bq3Lvp02cMthjK0+hVLcFmNc+XAhUQ4JdVe8kCmYLHEWX TQ6SuLPR7kyPF0zmpbY6KyISooPBJIeeD6+jDk4G6WB8YUmPTddewLfqKgLnCFE2Z8fA gQSw== X-Gm-Message-State: AAQBX9dcRSCJRvuBgFZPbKnVvyiVSq/7RIc0reYzDLVVuyPWO4BdDkkM ShZ2bS7FvzpRDdnbbrJvApU= X-Google-Smtp-Source: AKy350ZAFybFuC6UV5o+Av2B3qaWvPelSXC1+yQkwDZDZrxwesjGUcFtJ/jkq2lGEmn6lg1APX5eIw== X-Received: by 2002:a17:907:c710:b0:8b1:806b:7dbb with SMTP id ty16-20020a170907c71000b008b1806b7dbbmr10225413ejc.51.1679854757904; Sun, 26 Mar 2023 11:19:17 -0700 (PDT) Received: from kista.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id ja21-20020a170907989500b0093338259b2bsm11671117ejc.207.2023.03.26.11.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 11:19:17 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Sean Young , Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 110/117] media: sunxi-cir: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 20:19:16 +0200 Message-ID: <2550444.Lt9SDvczpP@kista> In-Reply-To: <20230326143224.572654-113-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> <20230326143224.572654-113-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_111921_942849_3E752B86 X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 26. marec 2023 ob 16:32:17 CEST je Uwe Kleine-K=F6nig napisal(= a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel