From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4533DC2BA1A for ; Thu, 20 Jun 2024 18:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v0x8ecTdm5ANsCH09S9Pb2MzQDN5bVSrn1Ej/5FXouk=; b=pQnNkY+Fbadibe4qH5UEt3xaIS U1FAfU0WIFNLQF0vPJAc4k55r03MznGJnN+F46i44/R11ML4J9VGJz0S5sf5DQn48P+R0lfSpiDKI GadujapXhuY2COXP4uqalCpZNwn7Xg8kTj6UOp6t2w6jhRGX2p5pyJKWxst3jKRsGE2RzUy2TR3A8 cxn9LYadCFGYfB/7CvZoaQDVSIRympZVhCfQmBF0BavnUTMbFZaSuO3HKAOi/wjoTb/ltl2NHFnIf El09/y5AH0ZV6US3RYUmZVue3Fq1PH4+hgQlwtU/C1GpvYG3sfqNhbQHNIpU5UcaloeHuJWhrTdpQ uGFl/oSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKMkC-00000006LAt-2ASY; Thu, 20 Jun 2024 18:42:48 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKMk9-00000006LAD-0fSk; Thu, 20 Jun 2024 18:42:46 +0000 Received: from i5e860cc8.versanet.de ([94.134.12.200] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKMk6-0000XY-Qs; Thu, 20 Jun 2024 20:42:42 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sebastian Kropatsch Cc: linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] arm64: dts: rockchip: Improve LEDs on NanoPi R6C/R6S Date: Thu, 20 Jun 2024 20:42:42 +0200 Message-ID: <2564239.kdYZ1jHi8b@diego> In-Reply-To: <20240612205056.397204-4-seb-dev@mail.de> References: <20240612205056.397204-1-seb-dev@mail.de> <20240612205056.397204-4-seb-dev@mail.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_114245_232499_33B108FA X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 12. Juni 2024, 22:48:12 CEST schrieb Sebastian Kropatsch: > Move led-3 node into NanoPi R6C/R6S's source files since they have > different functionalities on each board: On the R6S this LED is used > to signal LAN2 link up, while on the R6C this LED does not have a > pre-defined purpose. > > In addition to that: > - Remove deprecated label property > - Add color and function properties > - Add linux,default-trigger to trigger on Ethernet link Again, please don't group unrelated changes together into one patch. It makes things hard to read and hard to follow the changes. > > Signed-off-by: Sebastian Kropatsch > --- > > DT validation doesn't like the 'linux,default-trigger = "stmmac-0:01:link"' > properties, since "*:link" is not a valid value according to > [Documentation/devicetree/bindings/leds/common.yaml]. These LEDs do > have the specific purpose to show if an Ethernet link is up though. > There is one LED for each Ethernet port and they are labeled WAN and > LAN. > Using the 'linux,default-trigger' like this does work perfectly fine > with this solution. I could not find another way to achieve this. Please > let me know if there is a better way. > Maybe it would also be valid to add an entry to the DT bindings file to > allow "*:link" as a value for 'linux,default-trigger'? correct. If needed, things should be added to binding. Heiko