linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: max.schwarz@online.de (Max Schwarz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: rockchip: rk3188: enable pull-ups on UART inputs
Date: Thu, 13 Mar 2014 20:25:43 +0100	[thread overview]
Message-ID: <2567235.KcPFJfGIvp@typ> (raw)
In-Reply-To: <3174671.zfR1X00SEg@phil>

Hello Heiko,

> So I agree with you but would like to determine if we should also set the
> txd to pull down in one go, to restore the default pull setting of these
> pins or should leave them as is.
> Thoughts?
As soon as the UART is enabled, that TX pull-down does not do anything because 
the UART will actively drive the pin. I don't know what happens if the UART is 
suspended through runtime PM, though. I skimmed over the 8250_dw and saw 
support for that.

On the radxa board, there is even an external pull-up on the TX pin. The UART 
idle level is high, so that makes sense. If we wanted to pull the pin 
somewhere, I guess it should be up, not down. 

My vote would be to keep the patch as it is. In any case, it's an improvement 
of the status quo and does not change TX behavior.

Cheers,
  Max

  reply	other threads:[~2014-03-13 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09 19:43 [PATCH] ARM: rockchip: rk3188: enable pull-ups on UART inputs Max Schwarz
2014-03-13  0:36 ` Heiko Stübner
2014-03-13 19:25   ` Max Schwarz [this message]
2014-03-22 22:20     ` Heiko Stübner
2014-03-22 23:03       ` Max Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2567235.KcPFJfGIvp@typ \
    --to=max.schwarz@online.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).