From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@kernel.org>,
Thomas Richard <thomas.richard@bootlin.com>,
Andy Shevchenko <andy@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Andreas Werner <andreas.werner@men.de>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Sudeep Holla <sudeep.holla@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
patches@opensource.cirrus.com
Subject: Re: [PATCH 1/2] mfd: Constify mfd_cell arrays
Date: Fri, 30 Oct 2026 15:02:10 +0100 [thread overview]
Message-ID: <256cbe11-86ae-49e7-b7d6-0b0eb23a79e5@oss.qualcomm.com> (raw)
In-Reply-To: <20261030094515-afbbbd16-d834-4ef6-8910-e936476ea018@linutronix.de>
On 30/10/2026 09:47, Thomas Weißschuh wrote:
> On Fri, Oct 30, 2026 at 08:11:38AM +0100, Krzysztof Kozlowski wrote:
>> mfd_add_devices() takes pointer to const, so 'struct mfd_cell' arrays
>> can be constified whenever driver does not modify it in the probe.
>
> Looks like a candidate for scripts/const_structs.checkpatch.
I think no, too many false positives. 1/3 of drivers modify the mfd_cell.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-30 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 7:11 [PATCH 1/2] mfd: Constify mfd_cell arrays Krzysztof Kozlowski
2026-10-30 7:11 ` [PATCH 2/2] mfd: cgbc: Allow compile testing Krzysztof Kozlowski
2026-10-30 9:49 ` Andy Shevchenko
2026-10-30 10:00 ` Thomas Richard (congatec GmbH)
2026-10-30 8:24 ` [PATCH 1/2] mfd: Constify mfd_cell arrays Matti Vaittinen
2026-10-30 8:34 ` Chen-Yu Tsai
2026-10-30 8:47 ` Thomas Weißschuh
2026-10-30 14:02 ` Krzysztof Kozlowski [this message]
2026-10-30 9:23 ` Charles Keepax
2026-10-30 10:26 ` Thomas Richard (congatec GmbH)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=256cbe11-86ae-49e7-b7d6-0b0eb23a79e5@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andreas.werner@men.de \
--cc=andy@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=liviu.dudau@arm.com \
--cc=lpieralisi@kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mfd@lists.linux.dev \
--cc=patches@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=sudeep.holla@kernel.org \
--cc=thomas.richard@bootlin.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox