From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC299C352A1 for ; Tue, 6 Dec 2022 12:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FJt9jpwEeyyavZCNf8n46QAKgtOjLo6Bv0KzXRe7XT8=; b=1CYcAGHc45NO3a R38MYn7iO/zQcAjOI1hxbzPyj3eScODOSKzBOBQ+5aYU/5EBG4vwRmY8lSEatHEAjj858Kc03L69G G2coaB0BtZ4y0XVtcaaurO30SO5Xdbd9ismJ0yqfymf+pXI6zBDo16KDxrXYRVzqn9Usygl0eG8kR ti8HZbt3dIK2l2av3EPJMEaW+2XNXcN6IGp/rIiR2EgNuu2gUpW49yPliMrpqP4BwCoTf04neUpXE xAyFijW2h7y8pkLft9vdpS+L3oprQwaktryBFnKUrwVcB6TNbWaAXfk8yDGZ/RL5HvVn5hwlu9BcZ tfhP6outFQOKGCtMwCOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2X7E-0097Rw-PL; Tue, 06 Dec 2022 12:32:04 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2X7A-0097QP-Th for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 12:32:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670329918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DHp3x7R/guV3hbeucoqTiz42buTvLFKB8vI9+m0vRAc=; b=D8IwG+S5zN1MXxryo/fCbh6Ukt/pyOIUP5D5x14+YyEC+gihSMfWQRGJ+dyT5pZ/BwytnZ cZcJS2nok0YWsMYa/Kn+uhFHXv2E+yFCzZ3ztYkBchEgJT6oTltkhSC71I/3u+Se9aYeTm SyIz9epZnF7Flo1uPGBcLpx9QaBryKA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-16-teV6v5oqOLiZWrPeo8WZxg-1; Tue, 06 Dec 2022 07:31:56 -0500 X-MC-Unique: teV6v5oqOLiZWrPeo8WZxg-1 Received: by mail-wr1-f70.google.com with SMTP id p2-20020adfaa02000000b00241d7fb17d7so3147642wrd.5 for ; Tue, 06 Dec 2022 04:31:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DHp3x7R/guV3hbeucoqTiz42buTvLFKB8vI9+m0vRAc=; b=SQxNiOduE8YVMwYR2qB3CHGRZ6nVdywc7jbReM3QMCDg2FdOACqV5gwO7UGYdTZ9vk 4T3z075K3Y3RcEKZY479kPapH/nDbrOJsKUGS4CvMmLMI8uL81mrIuiZOVULY3ud+8Sc /cdmjLdNHmpmV5AgQsFwSDTcu9cTq3OhkxAoJOXsnHlMQ1oT8RpunmOtn7s4NANvZvi+ ecsXG3G9Vg5KiXQyCzEoWkG6rH0eL+kiVjH9fvpIq5rc2sx7E3qCBICVhOl0BORAPQxq 2EOaiDOavlkYPUsLpiJYdROzrScXZlXxJhuRqjRr+H6PBVh4qry7ePpoFVWnImqDHV+t XaCw== X-Gm-Message-State: ANoB5pkSl1oOp96n2LOeUNGFXuLlpvTOnRJ8fK8zp12sZv9BEMxYe8kI WVi3kdYsV1IM+hprgpH3vyj6mYGsugnuq8sK6JxLPMboZPK2/x9LqH05hdkGtjQNCsjtuxTYkLv Zic5mOTqy1/hG/OTSihTZCefXXeYMOHMVig8= X-Received: by 2002:adf:db85:0:b0:241:bfd7:de7 with SMTP id u5-20020adfdb85000000b00241bfd70de7mr50298114wri.254.1670329915715; Tue, 06 Dec 2022 04:31:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf7/qzzr0VuvbP4qZ7Yd3q9rLNeZH+c2AL9jutLoNZnaid8y/nFTvCdzJr8fgsaFlM4wi8oyFQ== X-Received: by 2002:adf:db85:0:b0:241:bfd7:de7 with SMTP id u5-20020adfdb85000000b00241bfd70de7mr50298102wri.254.1670329915442; Tue, 06 Dec 2022 04:31:55 -0800 (PST) Received: from gerbillo.redhat.com (146-241-106-100.dyn.eolo.it. [146.241.106.100]) by smtp.gmail.com with ESMTPSA id r2-20020a056000014200b002422bc69111sm20743265wrx.9.2022.12.06.04.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 04:31:55 -0800 (PST) Message-ID: <256f533f019b6392b41701707eb7aa056b2f16c0.camel@redhat.com> Subject: Re: [PATCH net-next v3 1/4] net: microchip: vcap: Add vcap_get_rule From: Paolo Abeni To: Horatiu Vultur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, Steen.Hegelund@microchip.com, lars.povlsen@microchip.com, daniel.machon@microchip.com, richardcochran@gmail.com, UNGLinuxDriver@microchip.com, olteanv@gmail.com Date: Tue, 06 Dec 2022 13:31:53 +0100 In-Reply-To: <20221203104348.1749811-2-horatiu.vultur@microchip.com> References: <20221203104348.1749811-1-horatiu.vultur@microchip.com> <20221203104348.1749811-2-horatiu.vultur@microchip.com> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_043201_083850_00E143F7 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Sat, 2022-12-03 at 11:43 +0100, Horatiu Vultur wrote: > @@ -632,32 +264,22 @@ static int vcap_show_admin(struct vcap_control *vctrl, > struct vcap_admin *admin, > struct vcap_output_print *out) > { > - struct vcap_rule_internal *elem, *ri; > + struct vcap_rule_internal *elem; > + struct vcap_rule *vrule; > int ret = 0; > > vcap_show_admin_info(vctrl, admin, out); > - mutex_lock(&admin->lock); > list_for_each_entry(elem, &admin->rules, list) { Not strictly related to this patch, as the patter is AFAICS already there in other places, but I'd like to understand the admin->rules locking schema. It looks like addition/removal are protected by admin->lock, but traversal is usually lockless, which in turn looks buggy ?!? Note: as this patch does not introduce the mentioned behavior, I'm not going to block the series for the above. Thanks, Paolo > - ri = vcap_dup_rule(elem); > - if (IS_ERR(ri)) { > - ret = PTR_ERR(ri); > - goto err_unlock; > + vrule = vcap_get_rule(vctrl, elem->data.id); > + if (IS_ERR_OR_NULL(vrule)) { > + ret = PTR_ERR(vrule); > + break; > } > - /* Read data from VCAP */ > - ret = vcap_read_rule(ri); > - if (ret) > - goto err_free_rule; > + > out->prf(out->dst, "\n"); > - vcap_show_admin_rule(vctrl, admin, out, ri); > - vcap_free_rule((struct vcap_rule *)ri); > + vcap_show_admin_rule(vctrl, admin, out, to_intrule(vrule)); > + vcap_free_rule(vrule); > } > - mutex_unlock(&admin->lock); > - return 0; > - > -err_free_rule: > - vcap_free_rule((struct vcap_rule *)ri); > -err_unlock: > - mutex_unlock(&admin->lock); > return ret; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel