From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A38CCD11C2 for ; Wed, 10 Apr 2024 08:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wb3B5wdsyaGADRkuD7Hd2o7S8SI7XkzFzmps657d1aY=; b=dIR7OJm9/sNldk VBX+IPTNSOwGKqZ5bK9ObizczjAlFIHvPFWQFRWduxE36bvAN61rZM0zmrp+KRuTTjIDGMv+AGymv /G8AEPPp7pT+mHbIqhbjBuF4AL8OnUrEN+pG/Z9aKKL4YYPI34yhAVIV0eALNEr2vubDbzx+u3waI 7OaFvA93Le7Yns9sSruIE1ksscbEKz/rdXuE6yBcPG/rlPdgBJRb8ujMuYpF4NayxXTnKK9YAQBqn ZSVSiA1jVLZA06Y5IDD8taGXHrP3zWpVU22dcBIDU/kJwNRlWDE+csAAE5ju9MqGWHuEY/3Jp4lp3 msTcSSgDVIlAF1wby2+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruTZ0-00000005w9M-1GQ8; Wed, 10 Apr 2024 08:44:14 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruTYw-00000005w6s-1yoM for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 08:44:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712738648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/8u8RiACrjH0Ov6QIh5KlQeJMTBnHt53gJzaMO3RSU=; b=J7h3myPLmbpEdWS7qtUuBPSxM9A4i1zzujV5kTK8QnFDG7Ph1FBnJkaiJN2JWnf5XyS24+ Eyc1Cb3bbV4nTyq4/AouFEBbclunj0d3lOoznUOSyb4cXgWe9HIJsg49SZ8Uf5/lX6/x9M zQLCDWBeELumsYCbhYy5sWpXdeGIXwU= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-z29lHrH5PPu6LQlx8lZHQQ-1; Wed, 10 Apr 2024 04:43:59 -0400 X-MC-Unique: z29lHrH5PPu6LQlx8lZHQQ-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1e50208ebe6so716855ad.1 for ; Wed, 10 Apr 2024 01:43:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712738639; x=1713343439; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R/8u8RiACrjH0Ov6QIh5KlQeJMTBnHt53gJzaMO3RSU=; b=ezfVlIBX8Jm0jJ622RuOdTmhlAyjYyd/qKQVMRyjahhRzd8Eg5a7YviDX99O3mI+Ob B9dXnz5Y/ED0apYKUz3ygEED2HO8W3a76X7aORhKVBtAXLlulm5UBfissdlLWI05xXSS kWNndnCrXQCTnqAd2lnOsZt7pB95sSSMfg2KZcSrgKq27wLXyqvlxDxGwzh1I9bvjAAc mzC3bdOH0Qn8vOyizOHMKQdyQ1yL350GGhVaaSx2IBogxmJGLiFb+kYPDSiKtH5pHs3Q gm9gi0Zt7hVVKJZrffjXRZDpca4d0rYtG/jYNjgYox73kqOTgQQJT4eYtSpNXN/VIEPb quvQ== X-Forwarded-Encrypted: i=1; AJvYcCWAoWa0pUnjjH9Kh+tfwDQEY41Hb1zEmYEC4sjTSDFsxeRYWy84737e+pe0Oeia3Y0C2AYjBlYLv7j/Ov+cmqYVO12Ni654DQpkulyihEK3j1qJYHI= X-Gm-Message-State: AOJu0YynNer7GFb/NsJhWY21tcyEGDG2XqFAcYqsJrB/ghscp7s8UJyC pA1ED58bAOtHM3QJnx3Tdzpmrv+b7hdGAjqAy7njw8ERiLgDZymf20g/5/wq9owP+EoCP+Serak hgmH0jAxUd0tjcYOAwXO+mOwLC+x4r4AR1EuUyFikNTzyfOqIaNnMi5jNzyN9hPQLFqRVlYbr X-Received: by 2002:a05:6a20:12c4:b0:1a8:2d22:2025 with SMTP id v4-20020a056a2012c400b001a82d222025mr2338659pzg.0.1712738638903; Wed, 10 Apr 2024 01:43:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwC+8hP4eRdQdzrRF5bUoyS6m0uCyKGnyeK7ZzH2kCnq17IDQmsibqG2jjTB0pS4pE6MLXUA== X-Received: by 2002:a05:6a20:12c4:b0:1a8:2d22:2025 with SMTP id v4-20020a056a2012c400b001a82d222025mr2338643pzg.0.1712738638521; Wed, 10 Apr 2024 01:43:58 -0700 (PDT) Received: from [10.66.61.39] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id d8-20020a170902cec800b001e41e968a61sm5696540plg.223.2024.04.10.01.43.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 01:43:58 -0700 (PDT) Message-ID: <25764b88-d1a5-4b9f-b2a1-2923f1adb979@redhat.com> Date: Wed, 10 Apr 2024 16:43:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] arm64: tlb: Fix TLBI RANGE operand To: Gavin Shan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, maz@kernel.org, oliver.upton@linux.dev, ryan.roberts@arm.com, apopple@nvidia.com, rananta@google.com, mark.rutland@arm.com, v-songbaohua@oppo.com, yangyicong@hisilicon.com, yihyu@redhat.com, shan.gavin@gmail.com References: <20240405035852.1532010-1-gshan@redhat.com> From: Shaoqin Huang In-Reply-To: <20240405035852.1532010-1-gshan@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_014410_638063_8B1C9800 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/5/24 11:58, Gavin Shan wrote: > A kernel crash on the destination VM after the live migration was > reported by Yihuang Yu. The issue is only reproducible on NVidia's > grace-hopper where TLBI RANGE feature is available. The kernel crash > is caused by incomplete TLB flush and missed dirty page. For the > root cause and analysis, please refer to PATCH[v3 1/3]'s commit log. > > Thanks to Marc Zyngier who proposed all the code changes. > > PATCH[1] fixes the kernel crash by extending __TLBI_RANGE_NUM() so that > the TLBI RANGE on the area with MAX_TLBI_RANGE_PAGES pages can > be supported > PATCH[2] improves __TLBI_VADDR_RANGE() with masks and FIELD_PREP() > PATCH[3] allows TLBI RANGE operation on the area with MAX_TLBI_RANGE_PAGES > pages in __flush_tlb_range_nosync() > > v2: https://lists.infradead.org/pipermail/linux-arm-kernel/2024-April/917432.html > v1: https://lists.infradead.org/pipermail/linux-arm-kernel/2024-April/916972.html > > Changelog > ========= > v3: > Improve __TLBI_RANGE_NUM() and its comments. Added patches > to improve __TLBI_VADDR_RANGE() and __flush_tlb_range_nosync() (Marc) > v2: > Improve __TLBI_RANGE_NUM() (Marc) > > Gavin Shan (3): > arm64: tlb: Fix TLBI RANGE operand > arm64: tlb: Improve __TLBI_VADDR_RANGE() > arm64: tlb: Allow range operation for MAX_TLBI_RANGE_PAGES > > arch/arm64/include/asm/tlbflush.h | 53 ++++++++++++++++++------------- > 1 file changed, 31 insertions(+), 22 deletions(-) > For the series. Reviewed-by: Shaoqin Huang -- Shaoqin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel