From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EA68C54FAA for ; Wed, 28 Aug 2024 13:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qUUiaCfBLXZWpJdappx4+njgqnXxefIpho9blRI4Pes=; b=e9XvYyXIp/gJU1GAqT8Nach+uS a5hS6ILoqYLGW5iNVbh75idFghU42a3R0nIU13hs2swiIAiYYGH7gF5/0gydBcf4yQhPNtOvgvIx6 O0bJ0+HKuL/qzWEXnyIyaZOj/gJ9IDM1QUvZEKMvAHkssbAYJTpK/7iM2UnnHfX+G0gXN5oqQB2ex /bDklfZAPlwHT46iNRasUo0jMx/JdZtjizpKD9i8EzqiNbDtEgJVTpayV2MgSa8rjaO4p6Xe4lyvf UZd62exCe72ONky+N8KHBojZ85KI3s8cTmsB0mDpqXsNxYozaA5pvhIO5g40+sxocRRkV/FMzLEW0 xiwcAnSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjIyF-0000000FZbN-0phb; Wed, 28 Aug 2024 13:44:23 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjIvQ-0000000FZ5Z-3aPP; Wed, 28 Aug 2024 13:43:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qUUiaCfBLXZWpJdappx4+njgqnXxefIpho9blRI4Pes=; b=h0mGQKeUHlQIzvXxOw2pBhnXnp 1gkRnQcgSpBgLRM91xDWAdbouRh+oqwwTl0pRZMjtkidxWkkdlHbym4+zv0vanCYCyAeYpzZMezF/ IWhrGWqZoOaoIA9mEFfl9dpfMNmjfBHfon0hmHYmuCBg40OjjA3WdeqJZBgYkjIPT8y/hkCUwCkIk xMi4a5KnL8Yg7h0GsAr+YWrY7/TqGF3wt9pz5376t0vKzCr5Od12SYu/B55lZEOa1BfdWoQkIHWxG 2GOOVfMngUSpq1Im2QF2UhWxsQyC+8qArm++5HOahS2BxYwzrXFCB9263I6nvaLXsLoRX9YLwqqFo //iudiqg==; Received: from i5e8616cd.versanet.de ([94.134.22.205] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sjIvL-0005dr-8m; Wed, 28 Aug 2024 15:41:23 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Jonathan Liu Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , FUKAUMI Naoki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: rockchip: Enable RK809 audio codec for Radxa ROCK 4C+ Date: Wed, 28 Aug 2024 15:42:35 +0200 Message-ID: <2576985.vzjCzTo3RI@diego> In-Reply-To: References: <20240828074755.1320692-1-net147@gmail.com> <2502361.uoxibFcf9D@diego> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_064129_034884_B4A96610 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, Am Mittwoch, 28. August 2024, 15:24:56 CEST schrieb Jonathan Liu: > On Wed, 28 Aug 2024 at 22:59, Heiko St=FCbner wrote: > > Am Mittwoch, 28. August 2024, 09:47:53 CEST schrieb Jonathan Liu: > > > This adds the necessary device tree changes to enable analog audio > > > output for the 3.5 mm TRS headphone jack on the Radxa ROCK 4C+ with > > > its RK809 audio codec. > > > > > > Signed-off-by: Jonathan Liu > > > > as it looks like you have one of those boards, could I possibly as you > > to take a look at the vdd_cpu_b and vdd_gpu nodes? > > > > I see (and devicetree check reports it too) a pinctrl-0 for the vsel-gp= io > > without accompanying pinctrl-names. > > > > Could you check if things fail if you either add pinctrl-names or remove > > the pinctrl-0 entry? >=20 > I tried both but neither resulted in any change to the warnings in dtbs_c= heck. > Reverting my change also results in the same warnings so I don't think > it is related to my change. I was more aiming at a functional test on the board :-) . You are correct in that this is not related to your change, I was just seeing someone with the hardware. I.e. while running dtbs check here I saw those regulator nodes and didn't want to change stuff without being able to test them. Heiko