From: Heiko Stuebner <heiko@sntech.de>
To: Douglas Anderson <dianders@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
mka@chromium.org, ryandcase@chromium.org,
Caesar Wang <caesar.wang@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: rockchip: Set the proper PWM for rk3288
Date: Thu, 11 Apr 2019 13:42:45 +0200 [thread overview]
Message-ID: <2577047.PMfDAGTXrs@phil> (raw)
In-Reply-To: <20190409204905.152432-1-dianders@chromium.org>
Am Dienstag, 9. April 2019, 22:49:05 CEST schrieb Douglas Anderson:
> The rk3288 SoC has two PWM implementations available, the "old"
> implementation and the "new" one. You can switch between the two of
> them by flipping a bit in the grf.
>
> The "old" implementation is the default at chip power up but isn't the
> one that's officially supposed to be used. ...and, in fact, the
> driver that gets selected in Linux using the rk3288 device tree only
> supports the "new" implementation.
>
> Long ago I tried to get a switch to the right IP block landed in the
> PWM driver (search for "rk3288: Switch to use the proper PWM IP") but
> that got rejected. In the mean time the grf has grown a full-fledged
> driver that already sets other random bits like this. That means we
> can now get the fix landed.
>
> For those wondering how things could have possibly worked for the last
> 4.5 years, folks have mostly been relying on the bootloader to set
> this bit. ...but occasionally folks have pointed back to my old patch
> series [1] in downstream kernels.
>
> [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1391597.html
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
applied for 5.2
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-04-11 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 20:49 [PATCH] soc: rockchip: Set the proper PWM for rk3288 Douglas Anderson
2019-04-11 11:42 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2577047.PMfDAGTXrs@phil \
--to=heiko@sntech.de \
--cc=caesar.wang@rock-chips.com \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=ryandcase@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).