From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 975CEC10F13 for ; Thu, 11 Apr 2019 11:42:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6629A2133D for ; Thu, 11 Apr 2019 11:42:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OELSuyEF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6629A2133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z3hnkzw4MNguJQWMCZwCdvf0M7RX9D9eErCqBqMf9Zg=; b=OELSuyEFn3gtRl eG+0trz6HB4gCz6SYstnZvLjODys2hh2FH+OuEmKihGgwtQUqw6kbb8KMC6CNgL9Ey+/mSUnu5UC+ HTwU8liP5DRCmoiMGvQWsDZ0xBVZ2TYcf6AVm1htxDM9Hv0bRwMUmjwd05HxCUwm1lhrT3vg9ibI0 KesIs2f6nzU3mi/s5YJM8BwrjEjSItL9pH1tVCB1kf40/PmHFGiCl9WFJJsaBTX59yjjdc60P+xzV G0F1yDFo5yJd9SsSdXH1K7j45U0yvMU5tbNsdZ4AvUGpNpjYBV8yDDZaDoZ+0epbZDwXD33RkxGsm a9a7ZHwmdoPr1FN/4oBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEY6Z-0002L8-Dt; Thu, 11 Apr 2019 11:42:55 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEY6V-0002K1-LH; Thu, 11 Apr 2019 11:42:53 +0000 Received: from wf0380.dip.tu-dresden.de ([141.76.181.124] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hEY6Q-0007YA-Et; Thu, 11 Apr 2019 13:42:46 +0200 From: Heiko Stuebner To: Douglas Anderson Subject: Re: [PATCH] soc: rockchip: Set the proper PWM for rk3288 Date: Thu, 11 Apr 2019 13:42:45 +0200 Message-ID: <2577047.PMfDAGTXrs@phil> In-Reply-To: <20190409204905.152432-1-dianders@chromium.org> References: <20190409204905.152432-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_044251_838961_9D0EE4E1 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Caesar Wang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 9. April 2019, 22:49:05 CEST schrieb Douglas Anderson: > The rk3288 SoC has two PWM implementations available, the "old" > implementation and the "new" one. You can switch between the two of > them by flipping a bit in the grf. > > The "old" implementation is the default at chip power up but isn't the > one that's officially supposed to be used. ...and, in fact, the > driver that gets selected in Linux using the rk3288 device tree only > supports the "new" implementation. > > Long ago I tried to get a switch to the right IP block landed in the > PWM driver (search for "rk3288: Switch to use the proper PWM IP") but > that got rejected. In the mean time the grf has grown a full-fledged > driver that already sets other random bits like this. That means we > can now get the fix landed. > > For those wondering how things could have possibly worked for the last > 4.5 years, folks have mostly been relying on the bootloader to set > this bit. ...but occasionally folks have pointed back to my old patch > series [1] in downstream kernels. > > [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1391597.html > > Signed-off-by: Douglas Anderson applied for 5.2 Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel