From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC011C36002 for ; Wed, 9 Apr 2025 09:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hwNQowCRrZKpoRjbSexMOK7xw0KAm2e2dAPubfMLQVo=; b=HkIyxQ0ykGhhwPfdVAJJiMZ1oF 7R97P/HbHHWDVYeJnL/01WZwBtBCXDoSZbnNxBJoVNVOYHhRUWGgdHGTV5x0x5wY7PzZm7B7Vmz5z Y96aOaIMMG1ue4iUA0nj1p3tx6Ag6axj0LEWKzH/H9csrLiz9WkaVyjWfrFh9YFjsIP+CXZ/Ie7DC CCAPdBDJO3L68O3VV+/ExN99387nI+ZCn8CNK+Hx8i7S3lP4dyss3Trg9KUMtLdYsW3KgX/jFOq7d 76uOzsjdrwMP9ehvs9nm31JKjPESzQ5Nh831s2e3SybhI0isD/2LNchYtg6RxbBVCer4jyrne/Qdi rE7Bq5fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2SCM-00000006lyS-09EH; Wed, 09 Apr 2025 09:58:22 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2SAb-00000006lgb-1gko; Wed, 09 Apr 2025 09:56:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=hwNQowCRrZKpoRjbSexMOK7xw0KAm2e2dAPubfMLQVo=; b=b6p80x6OxgbBfxUEYlkL5+O+HD V/JHlbPiQoyzO5Uulsg0gf1AGJJ+pP4oiDYpELlRMd8xd1TGRE8V8v90OGHxXEUddL0lqPiZS2JxY oBiNYqbSE/gBQkcY4OX+vwFnrDKXZOtJlK0y6esjXaW5l97GpdpB9UOtJBjFhEXMPKj8X0Z/TDt4u sidPOwHkVulyNZnYLEUNuK9lGU/pVf6JYjO/n4aAJFOyExSkQmfCD5ukIxeRMyIjbWfWGvIdQExeJ /+k1561whPQJWZxSQhxty8YKy7Nm44TIwL2LTq8DSiG2POwZwTVStGxfM+vy5fJjqT4DOkKhSo3+4 MLy9RL/A==; Received: from sea.source.kernel.org ([172.234.252.31]) by desiato.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u2SAY-00000008ZIg-019V; Wed, 09 Apr 2025 09:56:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 40AF449B02; Wed, 9 Apr 2025 09:56:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B178EC4CEEB; Wed, 9 Apr 2025 09:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744192584; bh=Rt/zFCT2dVTcx0v7PgWTkg2x2TmEPzbuCc7LGol1NJo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qWPe5feZ8pZyNgIE8UrI6Qe+5HR6c8wDH2s4C1DqPnOMRD2ktMdZnSdqh7dCkyLWi FP74r3nZP76ETGqCVpcNNDaZZsssd29J9NJxyVX9QoIMQlpnaoCezJx4hGlAAYEraz knt1yLB+bcGqG4liiQxunbx2M4AVlHo+SMRRg1hQO6FT7QP9/iZ3aYw2IqXCXN7vdT 2Yl00VKdRd1Pbpiy9Hxi/QwpX+IgjYH1J+uJDsWbA8drLstFyOn9HY49GXdxgLF/Fb CBIj5zIpwhsqr5DMGh8bPbOLs3AH6RVCcehA2xh3aqy/d3XNVzaoQb5dLI3R2G8Q6O kVOtNcCJ9xQvQ== Message-ID: <258c8fda-70cc-4624-aef6-7cbef3cdbde6@kernel.org> Date: Wed, 9 Apr 2025 11:56:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] memory: mtk-smi: mt8188: Use devm_pm_runtime_enable To: AngeloGioacchino Del Regno , Friday Yang Cc: Yong Wu , Rob Herring , Conor Dooley , Matthias Brugger , Philipp Zabel , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20250408033206.12176-1-friday.yang@mediatek.com> <20250408033206.12176-4-friday.yang@mediatek.com> <20250408-woodoo-quick-worm-bf82b4@shite> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_105630_532630_345B5EDD X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/04/2025 10:26, AngeloGioacchino Del Regno wrote: > Il 08/04/25 08:29, Krzysztof Kozlowski ha scritto: >> On Tue, Apr 08, 2025 at 11:31:56AM GMT, Friday Yang wrote: >>> Replace pm_runtime_enable with the devres-enabled version which >>> can trigger pm_runtime_disable. >>> >>> Signed-off-by: Friday Yang >>> --- >>> drivers/memory/mtk-smi.c | 16 +++++++++------- >>> 1 file changed, 9 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c >>> index f25d46d2ef33..daef6d350419 100644 >>> --- a/drivers/memory/mtk-smi.c >>> +++ b/drivers/memory/mtk-smi.c >>> @@ -713,16 +713,17 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) >>> if (ret) >>> goto err_link_remove; >>> >>> - pm_runtime_enable(dev); >>> + ret = devm_pm_runtime_enable(dev); >>> + if (ret) >>> + goto err_link_remove; >>> + >>> platform_set_drvdata(pdev, larb); >>> ret = component_add(dev, &mtk_smi_larb_component_ops); >>> if (ret) >>> - goto err_pm_disable; >>> + goto err_link_remove; >>> >>> return 0; >>> >>> -err_pm_disable: >>> - pm_runtime_disable(dev); >> >> You now broke/changed the order of cleanup without any explanation. >> >> Best regards, >> Krzysztof >> > > I agree some comment in the commit description saying that the cleanup reordering > doesn't matter in this specific case would've been nice to have, but anyway IMO > it's not a big deal - he didn't break anything, anyway :-) Cleanup orderings are tricky, so are you sure nothing got here called in incorrect moment? I see that runtime PM will be disabled much later and what certainty you have that device won't get resumed that time? Best regards, Krzysztof