* [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants
@ 2014-01-08 4:34 Simon Horman
2014-01-08 7:52 ` Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2014-01-08 4:34 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
v2
* Rebase: MSTPSR1 is now used
---
arch/arm/mach-shmobile/clock-r8a7779.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c b/arch/arm/mach-shmobile/clock-r8a7779.c
index 93a5625..8e403ae 100644
--- a/arch/arm/mach-shmobile/clock-r8a7779.c
+++ b/arch/arm/mach-shmobile/clock-r8a7779.c
@@ -47,17 +47,10 @@
#define MD(nr) BIT(nr)
-#define FRQMR IOMEM(0xffc80014)
#define MSTPCR0 IOMEM(0xffc80030)
#define MSTPCR1 IOMEM(0xffc80034)
#define MSTPCR3 IOMEM(0xffc8003c)
#define MSTPSR1 IOMEM(0xffc80044)
-#define MSTPSR4 IOMEM(0xffc80048)
-#define MSTPSR6 IOMEM(0xffc8004c)
-#define MSTPCR4 IOMEM(0xffc80050)
-#define MSTPCR5 IOMEM(0xffc80054)
-#define MSTPCR6 IOMEM(0xffc80058)
-#define MSTPCR7 IOMEM(0xffc80040)
#define MODEMR 0xffcc0020
--
1.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants
2014-01-08 4:34 [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants Simon Horman
@ 2014-01-08 7:52 ` Laurent Pinchart
2014-01-09 5:10 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2014-01-08 7:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
Thank you for the patch.
On Wednesday 08 January 2014 13:34:39 Simon Horman wrote:
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> v2
> * Rebase: MSTPSR1 is now used
> ---
> arch/arm/mach-shmobile/clock-r8a7779.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c
> b/arch/arm/mach-shmobile/clock-r8a7779.c index 93a5625..8e403ae 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7779.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7779.c
> @@ -47,17 +47,10 @@
>
> #define MD(nr) BIT(nr)
>
> -#define FRQMR IOMEM(0xffc80014)
> #define MSTPCR0 IOMEM(0xffc80030)
> #define MSTPCR1 IOMEM(0xffc80034)
> #define MSTPCR3 IOMEM(0xffc8003c)
> #define MSTPSR1 IOMEM(0xffc80044)
> -#define MSTPSR4 IOMEM(0xffc80048)
> -#define MSTPSR6 IOMEM(0xffc8004c)
> -#define MSTPCR4 IOMEM(0xffc80050)
> -#define MSTPCR5 IOMEM(0xffc80054)
> -#define MSTPCR6 IOMEM(0xffc80058)
> -#define MSTPCR7 IOMEM(0xffc80040)
>
> #define MODEMR 0xffcc0020
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants
2014-01-08 7:52 ` Laurent Pinchart
@ 2014-01-09 5:10 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-01-09 5:10 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 08, 2014 at 08:52:28AM +0100, Laurent Pinchart wrote:
> Hi Simon,
>
> Thank you for the patch.
>
> On Wednesday 08 January 2014 13:34:39 Simon Horman wrote:
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks, I will queue this up.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants
@ 2013-11-06 6:48 Simon Horman
2013-11-06 12:59 ` Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2013-11-06 6:48 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/clock-r8a7779.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c b/arch/arm/mach-shmobile/clock-r8a7779.c
index b7ce0e7..3083c70 100644
--- a/arch/arm/mach-shmobile/clock-r8a7779.c
+++ b/arch/arm/mach-shmobile/clock-r8a7779.c
@@ -47,17 +47,9 @@
#define MD(nr) BIT(nr)
-#define FRQMR IOMEM(0xffc80014)
#define MSTPCR0 IOMEM(0xffc80030)
#define MSTPCR1 IOMEM(0xffc80034)
#define MSTPCR3 IOMEM(0xffc8003c)
-#define MSTPSR1 IOMEM(0xffc80044)
-#define MSTPSR4 IOMEM(0xffc80048)
-#define MSTPSR6 IOMEM(0xffc8004c)
-#define MSTPCR4 IOMEM(0xffc80050)
-#define MSTPCR5 IOMEM(0xffc80054)
-#define MSTPCR6 IOMEM(0xffc80058)
-#define MSTPCR7 IOMEM(0xffc80040)
#define MODEMR 0xffcc0020
--
1.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants
2013-11-06 6:48 Simon Horman
@ 2013-11-06 12:59 ` Laurent Pinchart
2013-11-07 8:52 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2013-11-06 12:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
Thank you for the patch.
On Wednesday 06 November 2013 15:48:43 Simon Horman wrote:
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm/mach-shmobile/clock-r8a7779.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c
> b/arch/arm/mach-shmobile/clock-r8a7779.c index b7ce0e7..3083c70 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7779.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7779.c
> @@ -47,17 +47,9 @@
>
> #define MD(nr) BIT(nr)
>
> -#define FRQMR IOMEM(0xffc80014)
> #define MSTPCR0 IOMEM(0xffc80030)
> #define MSTPCR1 IOMEM(0xffc80034)
> #define MSTPCR3 IOMEM(0xffc8003c)
> -#define MSTPSR1 IOMEM(0xffc80044)
> -#define MSTPSR4 IOMEM(0xffc80048)
> -#define MSTPSR6 IOMEM(0xffc8004c)
> -#define MSTPCR4 IOMEM(0xffc80050)
> -#define MSTPCR5 IOMEM(0xffc80054)
> -#define MSTPCR6 IOMEM(0xffc80058)
> -#define MSTPCR7 IOMEM(0xffc80040)
It has been pointed out to me that the CPG requires waiting for clocks to be
enabled on all R-Mobile and R-Car SoCs. I've send a patch series to implement
this for r8a7790 ("[PATCH 0/2] ARM: shmobile: r8a7790: Wait for status on all
MSTP clocks"). Should we expand that to the other SoCs as well ? In that case
the constants would be needed.
> #define MODEMR 0xffcc0020
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants
2013-11-06 12:59 ` Laurent Pinchart
@ 2013-11-07 8:52 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-11-07 8:52 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 06, 2013 at 01:59:20PM +0100, Laurent Pinchart wrote:
> Hi Simon,
>
> Thank you for the patch.
>
> On Wednesday 06 November 2013 15:48:43 Simon Horman wrote:
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/mach-shmobile/clock-r8a7779.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c
> > b/arch/arm/mach-shmobile/clock-r8a7779.c index b7ce0e7..3083c70 100644
> > --- a/arch/arm/mach-shmobile/clock-r8a7779.c
> > +++ b/arch/arm/mach-shmobile/clock-r8a7779.c
> > @@ -47,17 +47,9 @@
> >
> > #define MD(nr) BIT(nr)
> >
> > -#define FRQMR IOMEM(0xffc80014)
> > #define MSTPCR0 IOMEM(0xffc80030)
> > #define MSTPCR1 IOMEM(0xffc80034)
> > #define MSTPCR3 IOMEM(0xffc8003c)
> > -#define MSTPSR1 IOMEM(0xffc80044)
> > -#define MSTPSR4 IOMEM(0xffc80048)
> > -#define MSTPSR6 IOMEM(0xffc8004c)
> > -#define MSTPCR4 IOMEM(0xffc80050)
> > -#define MSTPCR5 IOMEM(0xffc80054)
> > -#define MSTPCR6 IOMEM(0xffc80058)
> > -#define MSTPCR7 IOMEM(0xffc80040)
>
> It has been pointed out to me that the CPG requires waiting for clocks to be
> enabled on all R-Mobile and R-Car SoCs. I've send a patch series to implement
> this for r8a7790 ("[PATCH 0/2] ARM: shmobile: r8a7790: Wait for status on all
> MSTP clocks"). Should we expand that to the other SoCs as well ? In that case
> the constants would be needed.
That is a good question.
I am unsure if waiting is only required for Gen2 R-Car SoCs or
Gen1 as well. If it is requried for Gen1 then it would
make sense to extend the coverage of your series to H1 (r8a7779).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-09 5:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-08 4:34 [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants Simon Horman
2014-01-08 7:52 ` Laurent Pinchart
2014-01-09 5:10 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-11-06 6:48 Simon Horman
2013-11-06 12:59 ` Laurent Pinchart
2013-11-07 8:52 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).