From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD66DC4332F for ; Wed, 4 Jan 2023 09:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m9QeeEr2XIkyQzUkaDe5d0aqte3z6A8SC3nM+eM3n3c=; b=zrJGESDEnUwMGJ t1SJzsPVgcLFxqOCKx3sUP9fC1ktoLHQhUw/KLVb/j9Q9Xe5fb5p8LON3n/6wKO8khO9Pm3jUWHvT tdYOyzZksw7mjFAOq1pyKwKDC9PamC178kDOlSiujO6hiZ/E7NZYiOcP0Z3qUZFIBOigrmS5ftMlf SJXT0vBRrQ62VYem3D7afB6hGDQPaCehgsn52+Zg8QSFYSoDtPJoqqtbD7mtETQlcsxlX4rfTpPCc 7qeiRD0iTj9CiR9o1RgzOKbXVnVngEtSvNMGJ7PEPeo5MNqtkQz3OCgqn9c+oQSSWfEVY1SzewEH3 O6Rmo1q+f849UT9vZeFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD0BU-0086mQ-V6; Wed, 04 Jan 2023 09:35:45 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD06I-0083zF-Dk for linux-arm-kernel@lists.infradead.org; Wed, 04 Jan 2023 09:30:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1672824622; x=1704360622; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2rlN+2bLa8bUAn6Ge1/hCOYZUPOXVa3e1x+lsQpG/kU=; b=dEnz5s0wq1JsMYtzAXF5UP9Lu2jo+goUsI7/Dd+Jw6MPu97Rbc4a7XU+ 83NSfFD+UFNHgx7tsrUVdVcYAiMNImo/t2xbnjkjPSKR6ufvJvOVX57Cn lqHinz5qWRoWt2w0l9foOq/ZmNhKw3V6o2lCmKq1PR1ipqbkxTMnJgGgb GE8Rj6IgNIpv+BRYrc/Lga61k7isXCjuCzKtygHfh9d98QZpbUbnb7Y7F Qa1LA8w1ElaLAmpfKZ9mhxLt2CNRN6IL8eO8r6zkCMKplvCeLe7kmFE49 i6Z35CuFVB2arNJM7ahFzmxLCOHUYiybBmF9pTav/PMfnEwHhAQGL9hN8 Q==; X-IronPort-AV: E=Sophos;i="5.96,299,1665439200"; d="scan'208";a="28236673" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 04 Jan 2023 10:30:18 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 04 Jan 2023 10:30:18 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 04 Jan 2023 10:30:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1672824618; x=1704360618; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2rlN+2bLa8bUAn6Ge1/hCOYZUPOXVa3e1x+lsQpG/kU=; b=ShmhkEiMN2n1ebr2n6yXW+XAUdKY4lOQ6/RT6Wct0D/xANF1Ysoi2kTG 3rrslthe4crX0h9eENsDtMBGEYJgHZBR7XwfOtaAwU+7mC0na0qEnq+kf WOCsYytr8J7tbi0IXCSmynNAqkEg/3OGhC37BQbGxkBPkpxrkQIZpEGR/ 4OPF8oa9dfU4rfMandJ3kNQhd38FJsxEdDQHKwwLm1aHg4eHIADiLSszo 18XCgzC1aBIYnqso75g6wvjRraFGuA3iBjPnYg7R4QTVSMFyWLBKY8WaW JGdlWUQED0yAEtlB2yU28CqzG1mq6w/CRaKYtDL+3gaYxj//btA44zTZi Q==; X-IronPort-AV: E=Sophos;i="5.96,299,1665439200"; d="scan'208";a="28236672" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 04 Jan 2023 10:30:18 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 43851280056; Wed, 4 Jan 2023 10:30:18 +0100 (CET) From: Alexander Stein To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yang Yingliang Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, xiaolei.wang@windriver.com, l.stach@pengutronix.de Subject: Re: [PATCH v2] soc: imx8m: fix wrong return value check of of_clk_get_by_name() Date: Wed, 04 Jan 2023 10:30:15 +0100 Message-ID: <2597043.tIAgqjz4sF@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230104092702.2553290-1-yangyingliang@huawei.com> References: <20230104092702.2553290-1-yangyingliang@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230104_013023_355596_66EA4853 X-CRM114-Status: GOOD ( 18.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, thanks for the update. Am Mittwoch, 4. Januar 2023, 10:27:02 CET schrieb Yang Yingliang: > of_clk_get_by_name() never returns NULL pointer, it will return > ERR_PTR() when it fails, so replace the check with IS_ERR(). > > Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the > register") Signed-off-by: Yang Yingliang > --- > v1 -> v2: > Check WARN_ON() instead of checking IS_ERR(). > --- > drivers/soc/imx/soc-imx8m.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c > index 28144c699b0c..d1dbe318be53 100644 > --- a/drivers/soc/imx/soc-imx8m.c > +++ b/drivers/soc/imx/soc-imx8m.c > @@ -66,10 +66,8 @@ static u32 __init imx8mq_soc_revision(void) > ocotp_base = of_iomap(np, 0); > WARN_ON(!ocotp_base); > clk = of_clk_get_by_name(np, NULL); > - if (!clk) { > - WARN_ON(!clk); > + if (WARN_ON(IS_ERR(clk))) > return 0; > - } > > clk_prepare_enable(clk); Reviewed-by: Alexander Stein _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel