From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: zynq: DT: Add USB to device tree
Date: Tue, 02 Dec 2014 10:13:30 +0100 [thread overview]
Message-ID: <2598972.HWjIWPLUn8@wuerfel> (raw)
In-Reply-To: <71b9e172438946a5ba74efb430d1418c@BN1AFFO11FD060.protection.gbl>
On Monday 01 December 2014 13:51:26 S?ren Brinkmann wrote:
> Hi Arnd,
>
> On Mon, 2014-12-01 at 10:26PM +0100, Arnd Bergmann wrote:
> > On Monday 01 December 2014 10:42:32 Soren Brinkmann wrote:
> > > + usb_phy0: usb-phy at 0 {
> > > + compatible = "usb-nop-xceiv";
> > > + #phy-cells = <0>;
> > > + };
> > > };
> >
> > As discussed in an unrelated thread today, please drop the "@0" in the
> > node name, since the device has no 'reg' property.
>
> What is the best practice for naming such nodes then? On these boards
> it's not the case, but Zynq has two USB cores. So, there may be DTs that
> will have two phys in there. Would we just do 'usb-phy-0'?
>
>
Grant recommended naming them "phy0" and "phy1" in this case.
The recommended node name for a phy is "phy", not "usb-phy" (I didn't
notice that earlier, but it makes sense to change both), and
I would not use a dash for the number there.
Arnd
prev parent reply other threads:[~2014-12-02 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 18:42 [PATCH] ARM: zynq: DT: Add USB to device tree Soren Brinkmann
2014-12-01 20:26 ` Andreas Färber
2014-12-01 21:24 ` Sören Brinkmann
2014-12-01 22:56 ` Sören Brinkmann
2014-12-01 23:14 ` Andreas Färber
2014-12-01 23:16 ` Sören Brinkmann
2014-12-01 21:26 ` Arnd Bergmann
2014-12-01 21:51 ` Sören Brinkmann
2014-12-02 9:13 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2598972.HWjIWPLUn8@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox