From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30D94C77B72 for ; Sun, 16 Apr 2023 07:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PTK6i6Q1GrQnSbPAWohMzza9krax1buaHfuQdnqyUK0=; b=OqkGePv3Uyy1UF oRjZ8Vtn5RGLpDU8hmBHxR9vjpjS1OWO8v2XEYDOc3w8/mUud1rEe/9BxmGHJ947MJftMCg/M90rB mhN/qVUoSyGuYzvgbT4tl0Ngu5CHQTZOKlbS99scoEJ3HtNwMQwHuuD4MjspJY/PpgrBtrvLKSliE K1BRbFktK9ANeepOsydYy/y/MRl9H2OCSekctsTt/5N2D5JZZ8MxH+/Nq6oWTrbBbb+ACEz4FtR4r bwBYuFmlTcKgmQ3Fi5op3fCNvJYoEl02v1F1GgNxQAEnpClt7rVyMEQmqgcaNmXEQOSmbye1v/vPU iT3QFN1VH1P07uFERkWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnwni-00DInK-0C; Sun, 16 Apr 2023 07:27:54 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnwne-00DImm-1Z for linux-arm-kernel@lists.infradead.org; Sun, 16 Apr 2023 07:27:51 +0000 Received: by mail-ej1-x62d.google.com with SMTP id ud9so56117303ejc.7 for ; Sun, 16 Apr 2023 00:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681630067; x=1684222067; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=73bMhyNa0aa8++7vraJhEFeVzDGBZJo8oH+HWy7K7yA=; b=vIONb8S4Fov/w6lEJwtIY2XDOhURweSdmf2eYGoohCqBWvMR469wTlBOPxUOHrNLfq U7d3RheCV2V3RChebAvRCwecv0QtbwsTQOMJtcFBcqti8d9mtRIODisx1+6/pYcWOsPq vvEoIL4v2Zs5kdyRignjh8Pij88mZKU9Ro6UDknWcj3l6VJUvWAy5m1zoVHDDxMMYQA6 Urz1QYkyvIFOCE5MpYNT55ozc2rXofUXHfkgeSYRunxt6qs0qRjBR/IBSQND7I9UCuh5 FQUEYZ9Wsnc3sKwAVFlPNQ8AB7eH9VePhcTelqt3BqTt/o0rRwNx1VhMnc5qPvlJ36Nm wMvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681630067; x=1684222067; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=73bMhyNa0aa8++7vraJhEFeVzDGBZJo8oH+HWy7K7yA=; b=YG76Ol/PWifAUCm6uL153yuqArymcJwOaxR2AdOzHfucXBT0SIkPpkqWe+YhcBXxRL oR8BaGax/8gYT7jrtdMch5Z0EV+/uW8rxA1JQjA9MP5RMrUzWIymBo8bToHQHp3cDL0G rGhgvMGgNjh5N/fBLGvCmh227l5Qz7ny8Vd4eCmKshaO/ARZUaSbFLsDeZIMKveuFIgb rO/vjfdPjbHQaH9PU2CrJftShhXrnY42mlPurpAwoShB5QLVv6C0l9QUMoSkQKFOkfcL sh+NhPkEmFKk9+I5Uhzpq9RfD2Ejvq2yU+fbiJiW3wUxJCqrJlG7SBpgaAjuiyUN6G+g yzwA== X-Gm-Message-State: AAQBX9dt+9uAbZpJFPmAs7+9buPNMrFK2kGppVarb395wYBtgdtS6dah dJC4THNiuTCYmetGJ5iGWcsY9w== X-Google-Smtp-Source: AKy350ajcg5svPODaCy5GefECc0x96HqXNNX3Q6QNl7eIsMc6jJRAr0jWQmn+ooPujRSUW5OZDiWvQ== X-Received: by 2002:a17:906:82c5:b0:94a:8e19:6aba with SMTP id a5-20020a17090682c500b0094a8e196abamr3986530ejy.21.1681630067634; Sun, 16 Apr 2023 00:27:47 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:29dd:ded4:3ccc:83db? ([2a02:810d:15c0:828:29dd:ded4:3ccc:83db]) by smtp.gmail.com with ESMTPSA id s4-20020a170906500400b0094776b4ef04sm4821709ejj.10.2023.04.16.00.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 00:27:47 -0700 (PDT) Message-ID: <25a8dcf9-fd1b-0eb3-eced-7a1e158ca7fc@linaro.org> Date: Sun, 16 Apr 2023 09:27:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 3/3] ARM: dts: axp209: Add iio-hwmon node for internal temperature Content-Language: en-US To: Jonathan McDowell , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230416_002750_529586_B291EAD6 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/04/2023 19:47, Jonathan McDowell wrote: > This adds a DT node to hook up the internal temperature ADC to the Do not use "This commit/patch", but imperative mood. See: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > iio-hwmon driver. The various voltage + current ADCs are consumed and > exposed by their respective drivers, but this is not and is always > available. Naming chosen to match the axp20x_ prefix the power sensors > use. Weird choice. > > Signed-off-by: Jonathan McDowell > --- > arch/arm/boot/dts/axp209.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi > index ca240cd6f6c3..f00b5a7ec106 100644 > --- a/arch/arm/boot/dts/axp209.dtsi > +++ b/arch/arm/boot/dts/axp209.dtsi > @@ -48,6 +48,13 @@ > * http://dl.linux-sunxi.org/AXP/AXP209%20Datasheet%20v1.0_cn.pdf > */ > > +/ { > + axp20x_temp { No underscores in node names. Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "iio-hwmon"; > + io-channels = <&axp_adc 4>; /* Internal temperature */ > + }; > +}; > + > &axp209 { > compatible = "x-powers,axp209"; > interrupt-controller; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel