From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E09C0C3DA64 for ; Wed, 31 Jul 2024 06:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gojGMfkKjsM9J6aga5vnl6TY2q5uJ85vagSCFyyceU0=; b=O9KauZ5HK3ikhr2yg14oOAJGtv 9hW9yPRHcW1O7RzlzYnDoYFDI109qbgKLctgmrX3hm/TEYUVKEsZIrH5fjImpndzlg7TDsw4klZS1 FatYi2qZ4E8CaG4LoFaJPRizGtIlMYrv7N+P5RQH9WfhNc3zJyWyiRtacNmQQ5iZBdjaJRdtr+bLQ g6YoO9EGHW7+nTI3HZNf47JIo9Y9qrHeEM4QwS+x29/ur5j0Da4mQjFhJ9BpabROnX5M3Vk/8nSOH OlqzigXCUs/vcPMoqnEpN1Vp2+oWvoMsb4ZdqmvMq/1IEuM6CxddoGCOOvOUa1bbjWqjCNJe2jJPU uKyFGNPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ2Pa-0000000HSAA-296R; Wed, 31 Jul 2024 06:02:10 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ2P8-0000000HS7A-27Lf for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 06:01:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1722405694; bh=gojGMfkKjsM9J6aga5vnl6TY2q5uJ85vagSCFyyceU0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Y+FLFMrB/2bHdm2VqEOmMjhfpLWLytJyLcAfytsqz+42qV7eCWCiD31jvHFVfSzBg oK79Bo7dQNkecMYQfqjTeGSRxabnWt4RedzjaaiqrUaFFMmTay9B1P9F+zvcdvxD+F 8hYfcF3dNf9Q5mis2ti049+EYUVUXavbJM2VIUNcfQNVzjywIXyxFBsWlysEkxhspj E6JZ0hLeBkoEUJdb3Ms+EjLCOyaG/3nKPokw/htbi75FdHGaKED7FgR4D80ozoherm zNtvNvDsyXZ/gyeebM0IgloswHa0lzIJUcj2W3NqjYESGMm7MblRyU/NpLW66v6g7K bOy/wpv5s+zmA== Received: from [192.168.68.112] (ppp118-210-29-70.adl-adc-lon-bras31.tpg.internode.on.net [118.210.29.70]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 2C48664C85; Wed, 31 Jul 2024 14:01:26 +0800 (AWST) Message-ID: <25b2bc6b5b4aec33396f4d6960654e65bf1c3d6e.camel@codeconstruct.com.au> Subject: Re: [PATCH] i2c: don't use ',' after delimiters From: Andrew Jeffery To: Wolfram Sang , linux-i2c@vger.kernel.org Cc: Jean Delvare , Andi Shyti , Elie Morisse , Shyam Sundar S K , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Baruch Siach , Dong Aisheng , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Janusz Krzysztofik , Vignesh R , Vladimir Zapolskiy , Krzysztof Kozlowski , Alim Akhtar , openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org Date: Wed, 31 Jul 2024 15:31:25 +0930 In-Reply-To: <20240730220401.3649-2-wsa+renesas@sang-engineering.com> References: <20240730220401.3649-2-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_230142_786294_9F4F63F6 X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2024-07-31 at 00:01 +0200, Wolfram Sang wrote: > Delimiters are meant to be last, no need for a ',' there. Remove a > superfluous newline in the ali1535 driver while here. >=20 > Signed-off-by: Wolfram Sang > --- >=20 > @Andi: These changes are super trivial so I put them into one patch. Let > me know if you prefer broken out patches. I think it is better if it > goes through your tree, but I can also take if you prefer. >=20 > drivers/i2c/busses/i2c-ali1535.c | 3 +-- > drivers/i2c/busses/i2c-amd-mp2-plat.c | 2 +- > drivers/i2c/busses/i2c-aspeed.c | 2 +- Thanks for the cleanup. For the Aspeed portion: Acked-by: Andrew Jeffery