From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E863C433EF for ; Tue, 7 Jun 2022 15:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3CVkCghh75Nw7MqHWIzAXohkJKZyMjjx/tjp77orAKU=; b=mSULn/O8w4um41 /wYG5BcjmFOWoZ3QiljiKi5dr8WvWbSQOseJ+f2hycK4OoCCWiea3h8C26DT7biLCEp9Y19V78k5y rrJUbXSOpiHM5AxQ0NeVnARaUOtfyuU6cEsGJkMVswlY9jhkDXIY20BTAPD9o0H5wCW0rMFZ+wqzb 5taw5MnkbtH29uY1zdbWq+q0v0J6Lpar86Fr76mNsqimTMhGwdRLg434BZ7LBKxgN+Wjjt+wTobLg 1fht189duKQP24vicw133DHUfNCnnHu+6kiCzvfTBBTXNYa2e0pFmK304a6+USiLzNU0LXMpddalz nBNr++ahHwL+f+kZDBvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nybF8-008JEc-Fv; Tue, 07 Jun 2022 15:35:42 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nybF5-008JDd-Fi for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 15:35:40 +0000 Received: by mail-wm1-x336.google.com with SMTP id n124-20020a1c2782000000b003972dfca96cso9725385wmn.4 for ; Tue, 07 Jun 2022 08:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=UzAFOh0dSi5b7YcRWFXZow4QCyM7X3zyC4kDiKLs6oA=; b=T5kR40O4jIf93Fzt2vVjHZsWJdRsDbXUsWf+mvn1wIXbxiVgaP5IefQAlFt7hUxPLw rUHJnaENpHIaQQ5LD5GYbGFLr/ivNwinMXUz3J/LMQc0uSeEv5klV5kQgxojKKCrqT6K z8O5hGcPPFVeRibn0sn6StjcyJugXjVuKtNDos/NoE4mFB64LDwtgd4zef/99rLnWwm4 vQIC98SKhKJePLMpRBVse3kuDKRKqQvLkTE3ABXMs6kjiVEwmUQzkVohuwLxerT1z9sa 0mFV7MhEypGwD8gH/3TNX6QqtchzS5h+UoteVBwLpPaJlUYlXl00HMEKhepD5Y/Nbv7U 0HvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=UzAFOh0dSi5b7YcRWFXZow4QCyM7X3zyC4kDiKLs6oA=; b=dfj41vncbnRfDI7lrga2Mqv48vgQqQvq6evg16HPn4TYf4rzRkzso6l+3xy81TvPDi DuDOtpZXCkF5x3fs5IhRZ9D3pAi3+x1ZZuVN53UWaH1SU0u1udv589NByPggKlOjJgp1 ukrAtZTAu6ypL1a9K3LQx+YzwnPy26Vx85L6OIHy6NQ3XipxvQbTlm6S1Q44ZsczvHxX jdmrUeYshO+r/a9wmN5Q/iJUjnUeH6RSyDvfCApQLersvgmaI2uKnrStq3XAg5jWxtqE Axx4i2bKVY6bQMBqYAvsEP9HX+61RHZxJ2p2Lr3fGkZJKHlWPHLMyemY56fIc2A8KxKx MZXQ== X-Gm-Message-State: AOAM533Zvuvk6fIGK0txtRfcZldH1vmYKwuw62570cJD+Yz90vMjlEo2 diZlXJypf63NShfZMbyI73MgAA== X-Google-Smtp-Source: ABdhPJy6bavYQeyfic2q5zoBbUISR1gSP0m3TPaWhyrDKXYy9SywIwfxjCPR6erasubUzeaAz8h6gQ== X-Received: by 2002:a05:600c:2054:b0:39c:3f73:3552 with SMTP id p20-20020a05600c205400b0039c3f733552mr23997611wmg.15.1654616135853; Tue, 07 Jun 2022 08:35:35 -0700 (PDT) Received: from [192.168.187.211] ([86.12.200.143]) by smtp.gmail.com with ESMTPSA id s13-20020a5d6a8d000000b0020c5253d8f7sm18217141wru.67.2022.06.07.08.35.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 08:35:35 -0700 (PDT) Message-ID: <25c1a57e-af67-ebc8-ab13-6532bf6e6e75@raspberrypi.com> Date: Tue, 7 Jun 2022 16:35:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] ARM: initialize jump labels before setup_machine_fdt() To: "Jason A. Donenfeld" Cc: Russell King - ARM Linux , Russell King , linux-arm-kernel , LKML , Catalin Marinas , Stephen Boyd , Ard Biesheuvel , stable References: <8cc7ebe4-442b-a24b-9bb0-fce6e0425ee6@raspberrypi.com> <8c3fe744-0181-043a-3af9-dd00165a6356@raspberrypi.com> From: Phil Elwell In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_083539_648856_F7FC475F X-CRM114-Status: GOOD ( 20.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Jason, On 07/06/2022 16:14, Jason A. Donenfeld wrote: > Hey again, > > On Tue, Jun 07, 2022 at 10:15:27AM +0100, Phil Elwell wrote: >> On 07/06/2022 09:43, Jason A. Donenfeld wrote: >>> Hi Phil, >>> >>> On Tue, Jun 7, 2022 at 10:29 AM Phil Elwell wrote: >>>> >>>> This patch is fatal for me in the downstream Raspberry Pi kernel - it locks up >>>> on boot even before the earlycon output is available. Hacking jump_label_init to >>>> skip the jump_entry for "crng_is_ready" allows it to boot, but is likely to have >>>> consequences further down the line. >>> >>> Also, reading this a few times, I'm not 100% sure I understand what >>> you did to hack around this and why that works. Think you could paste >>> your hackpatch just out of interest to the discussion (but obviously >>> not to be applied)? >> >> This is the minimal version of my workaround patch that at least allows the >> board to boot. Bear in mind that it was written with no previous knowledge of >> jump labels and was arrived at by iteratively bisecting the list of jump_labels >> until the first dangerous one was found, then later working out that there was >> only one. > > Looks like this patch fails due to CONFIG_STRICT_KERNEL_RWX. > Investigating deeper now, but that for starters seems to be the > differentiating factor between my prior test rig and one that reproduces > the error. I assume your raspi also sets CONFIG_STRICT_KERNEL_RWX. Yes, it does, as does multi_v7_defconfig. Phil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel