From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1D53C52D6F for ; Sat, 24 Aug 2024 15:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mLkI2aUTuni9NFuB5OOLVo8J+M0TP1LBFtceUNfr7a8=; b=AXswp8yIQoYDsWy6s4FU8C9ocn dxOMujMr0LK8rGY69WdjzU3S8rdx614DzEORZRtsu7vodqmsM9VZKaoIzIZt9+FWx08zHkfFp70EC wqf/T8ChFRw+9Za35QCpxcOR6F+V+glqffzedrjDCfbg7HlEppxctooPmbya50U4gLduVIHfCtWzb BOAmD2wX67UG+PPub3GQxLz6OI6PYYp4kMiqRHMTTbQah53zprumcCIaIinS57qRmiZPK3KVDu1Y7 Sog3c1Q3QR7rROOD13PTJW2c1LeNs5KIzSxZicdM12kcEK86ACOpBaRBHJ+tbO6R0sYCvtuyyw7cW iAR+/FcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sht6K-00000002U9j-41uq; Sat, 24 Aug 2024 15:54:53 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sht54-00000002Tri-2XJg for linux-arm-kernel@lists.infradead.org; Sat, 24 Aug 2024 15:53:36 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5bed68129a7so3906625a12.2 for ; Sat, 24 Aug 2024 08:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724514813; x=1725119613; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mLkI2aUTuni9NFuB5OOLVo8J+M0TP1LBFtceUNfr7a8=; b=qcoDg2HZstLsEtpMf5KdK7l56T1kJZ9KI+GLwWt1y8xYAZURlEuhH3RNOoEQEYd7Xg JcSU5v6TMpjZBt30gLGTtg9IBw405qxx/bJFj0IuNTD2AWsJ8YExFrlgJKm1/87+owfL dD1Xj2Wz5Q+h7YXmyGrLSIoAAavY1SgM4Jq3oeRf/tDBMsCfbOndgfAa0S3x9mMDpRJ6 xc1DEq1pprOa+Ig9NZ6IYjsna3u80PPcNqvJjGLTEpjTJTv4jsalGEY6r1CaW2AXk8y4 835/oXXImNper/2MnqKXO0yGWqHw3uyTPeZKXKggzvPp6Q+gGgNSe3qLp2cBP0IDFgcw +QyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724514813; x=1725119613; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mLkI2aUTuni9NFuB5OOLVo8J+M0TP1LBFtceUNfr7a8=; b=DBJepXcWK2L8IPg8Z8ZqH2dWjlwAsD3XRHbkOzS9S0hjJAqByhqHfpWwtfBIatNhb+ RfzIpnWdyqscxLDTD++nmbt9dkILemVQkWaKHLWgjfcJXA9c3ABc8w1LPqtdnxsYcpoL kLMrp18m8AKkDkn2VKVDbmexdcJr/U5fd4UQgE+Fw0V7e5HNM5781ICkjOJ2y8Cz0Gf7 9B2uyvIe8da6WBjuOLnO9lntfWPyUeUrtYJlRhAkgO+RKL84nTBAEMjDlwpdLm+UxXvK mnNkR5jT72ADbiTtDJ5w0zESOL1BgpnO3ZC8H9eybmI5kMCvYmcTuUsL+y9FpPHS4jVf T/7w== X-Forwarded-Encrypted: i=1; AJvYcCUTwOU4o+1U7/utxq8KEZwPkUgRVnNG+T/e/kj/UGYdNARN9T1Qa3mXCvHx3A9kS8Yez7aimrucDOpIXE8Zz7G3@lists.infradead.org X-Gm-Message-State: AOJu0YxlL3TpvPYc/mcJrlTZkXQoZrM4376BuVNFuoLPzeI5busoxce1 Y5VP2mGb5W/X37OXxk0X9xGNK3dUMAXENH3EqNw3rXNWaoPW1HW54VuEfazd3rUFZIYR1hCESF+ A X-Google-Smtp-Source: AGHT+IGDaXHidgJHARyBVubzO2NqL+q6YUKRQZn6433SWaj5ajYCUpE1q0Y1qN+NTxESjaN4CpGx2g== X-Received: by 2002:a05:6402:90b:b0:5be:bcdf:4110 with SMTP id 4fb4d7f45d1cf-5c08910fb32mr4066408a12.0.1724514812785; Sat, 24 Aug 2024 08:53:32 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3ca4d2sm3434336a12.36.2024.08.24.08.53.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2024 08:53:32 -0700 (PDT) Message-ID: <25dcd6bb-5586-4b32-9a12-7e82126cc876@tuxon.dev> Date: Sat, 24 Aug 2024 18:53:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/12] nvmem: microchip-otpc: Enable main RC oscillator clock Content-Language: en-US To: Alexander Dahl Cc: Christian Melki , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" , open list References: <20240821105943.230281-1-ada@thorsis.com> <20240821105943.230281-12-ada@thorsis.com> From: claudiu beznea In-Reply-To: <20240821105943.230281-12-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240824_085334_682041_AED74517 X-CRM114-Status: GOOD ( 20.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21.08.2024 13:59, Alexander Dahl wrote: > Without enabling that clock, initializing the packet list leads to a > read timeout on the first packet. > > According to SAM9X60 datasheet (DS60001579G) section "23.4 Product > Dependencies" the clock must be enabled for reading and writing. > > Tested on sam9x60-curiosity board. > > Signed-off-by: Alexander Dahl > --- > drivers/nvmem/microchip-otpc.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c > index a80535c3d162..047ca5ac6407 100644 > --- a/drivers/nvmem/microchip-otpc.c > +++ b/drivers/nvmem/microchip-otpc.c > @@ -8,6 +8,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -54,6 +55,7 @@ > struct mchp_otpc { > void __iomem *base; > struct device *dev; > + struct clk *clk; > struct list_head packets; > u32 npackets; > }; > @@ -272,6 +274,15 @@ static int mchp_otpc_probe(struct platform_device *pdev) > if (IS_ERR(otpc->base)) > return PTR_ERR(otpc->base); > > + // NOTE: Maybe make this optional, especially if sama7g5 testing Looking though DS, on SAMA7G5 the clock here should be MCK0. I think it should be added for SAMA7G5, too, with a fixes tag. > + // shows the clock is not required there? Use C style comments /* comment */ > + otpc->clk = devm_clk_get_enabled(&pdev->dev, "main_rc_osc"); Maybe name it "bus-clk", "bus" or something otpc specific. > + if (IS_ERR(otpc->clk)) { > + dev_err(&pdev->dev, "Error (%ld) getting clock!\n", > + PTR_ERR(otpc->clk)); > + return PTR_ERR(otpc->clk); return dev_err_probe(). > + } > + > reg = readl_relaxed(otpc->base + MCHP_OTPC_WPSR); > if (reg) > dev_warn(&pdev->dev,