From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: pxa-dt and multiple platforms support
Date: Sat, 27 Sep 2014 21:56:10 +0200 [thread overview]
Message-ID: <2605016.XXNIkQVRuo@wuerfel> (raw)
In-Reply-To: <8738bcdf2r.fsf@free.fr>
On Saturday 27 September 2014 21:43:40 Robert Jarzmik wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > I think it should be easy enough to move the function declarations you need out of
> > mach/pxa3xx.h and mach/pxa27x.h into a file that is shared between the platforms,
> > and that is included by both. The DT file won't need the register definitions
> > or a lot of the other things that are provided by mach/pxa3xx.h.
>
> Yes, I had thought of that, and generic.h would be a good candidate.
>
> I have not mentioned it because there is one thing I'm afraid of : should we
> discover that any pxa variant initialization requires one register to be
> accessed, then the pxa-dt should be split into several pxaXXX-dt.c anyway.
>
> It is not the case AFAIK. I'm pondering the risk against having 2 split apart
> files ...
The register definitions are total crap and you shouldn't use them for the
DT file anyway. If you get to the point where you have to touch some
registers, I think the right answer would be to have a DT node for the
register block and use of_iomap with a platform specific offset, or
a proper device driver.
It's more likely that you won't actually need this though.
Arnd
prev parent reply other threads:[~2014-09-27 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 17:56 pxa-dt and multiple platforms support Robert Jarzmik
2014-09-27 18:08 ` Daniel Mack
2014-09-27 19:29 ` Arnd Bergmann
2014-09-27 19:43 ` Robert Jarzmik
2014-09-27 19:56 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2605016.XXNIkQVRuo@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox