From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 2/3] ARM: dts: rockchip: remove include for irq.h
Date: Fri, 03 Apr 2020 18:08:04 +0200 [thread overview]
Message-ID: <2606579.xTHnjFkxbI@phil> (raw)
In-Reply-To: <20200403154329.11256-2-jbx6244@gmail.com>
Hi Johan,
Am Freitag, 3. April 2020, 17:43:28 CEST schrieb Johan Jonker:
> The 'irq.h' file is already included through 'arm-gic.h',
> so remove them from all Rockchip dtsi files.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> arch/arm/boot/dts/rk3036.dtsi | 3 +--
> arch/arm/boot/dts/rk322x.dtsi | 3 +--
> arch/arm/boot/dts/rk3288.dtsi | 5 ++---
> arch/arm/boot/dts/rk3xxx.dtsi | 1 -
> arch/arm/boot/dts/rv1108.dtsi | 4 ++--
> 5 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
> index 781ac7583..55f3838b2 100644
> --- a/arch/arm/boot/dts/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rk3036.dtsi
> @@ -1,10 +1,9 @@
> // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>
> +#include <dt-bindings/clock/rk3036-cru.h>
> #include <dt-bindings/gpio/gpio.h>
> -#include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/pinctrl/rockchip.h>
> -#include <dt-bindings/clock/rk3036-cru.h>
> #include <dt-bindings/soc/rockchip,boot-mode.h>
that movement of the *-cru.h files are unrelated changes,
as they're not described in the commit message.
If you really want to move these this should be a separate commit.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-03 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 15:43 [PATCH v2 1/3] ARM: dts: rockchip: remove identical #include from rk3288.dtsi Johan Jonker
2020-04-03 15:43 ` [PATCH v2 2/3] ARM: dts: rockchip: remove include for irq.h Johan Jonker
2020-04-03 16:08 ` Heiko Stuebner [this message]
2020-04-03 15:43 ` [PATCH v2 3/3] arm64: " Johan Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2606579.xTHnjFkxbI@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).