From: Heiko Stuebner <heiko@sntech.de>
To: guoweix <2298701336@qq.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
f.kardame@manjaro.org, pgwipeout@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
guoweix <2298701336@qq.com>
Subject: Re: [PATCH] arm64: dts: rockchip: fix rk809 interrupt pin on rk3566-roc-pc
Date: Mon, 27 Apr 2026 13:41:24 +0200 [thread overview]
Message-ID: <26138973.6Emhk5qWAg@phil> (raw)
In-Reply-To: <tencent_CF3170E7191769F8FB22C55A0F952E82E105@qq.com>
Hi,
Am Mittwoch, 8. April 2026, 17:09:44 Mitteleuropäische Sommerzeit schrieb guoweix:
> The RK809 PMIC interrupt pin on the Firefly ROC-RK3566-PC (Station M2)
> is physically connected to GPIO0_A3 (RK_PA3) according to the board's
> schematic.
>
> Currently, the PMIC node incorrectly specifies RK_PA7 for the interrupt,
> which prevents the PMIC from correctly signaling interrupts. (Note that
> the pinctrl node 'pmic_int' correctly configures RK_PA3).
>
> Fix this by updating the interrupts property to use RK_PA3.
>
> Fixes: 30ac9b4e25d8 ("arm64: dts: rockchip: add dts for Firefly Station M2 rk3566")
>
> Signed-off-by: guoweix <2298701336@qq.com>
Could you use the more standard naming of "given name + surname" please?
For example with:
git commit --amend --author="givenname surname <2298701336@qq.com>"
Or setting user.name in your .gitconfig.
Patch otherwise looks good.
Thanks a lot
Heiko
> ---
> arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> index 7e499064e035..985770e3a5e2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> @@ -245,7 +245,7 @@ rk809: pmic@20 {
> compatible = "rockchip,rk809";
> reg = <0x20>;
> interrupt-parent = <&gpio0>;
> - interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
> clock-output-names = "rk808-clkout1", "rk808-clkout2";
> assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
> assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
>
prev parent reply other threads:[~2026-04-27 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 15:09 [PATCH] arm64: dts: rockchip: fix rk809 interrupt pin on rk3566-roc-pc guoweix
2026-04-27 11:41 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26138973.6Emhk5qWAg@phil \
--to=heiko@sntech.de \
--cc=2298701336@qq.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.kardame@manjaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox