Re: [PATCH 2/2] arm64: dts: amlogic: t7: khadas-vim4: add PWM-driven status LED

[Ronald Claveau <linux-kernel-dev@aliel.fr>]

On 5/13/26 10:05 AM, Neil Armstrong wrote:
> On 5/12/26 19:47, Ronald Claveau via B4 Relay wrote:
>> From: Ronald Claveau <linux-kernel-dev@aliel.fr>
>>
>> The VIM4 board exposes a status LED wired to the PWM_AO_C_D output.
>> Enable the pwm_ao_cd controller with its pinmux, and declare a
>> pwm-leds node with a heartbeat trigger.
>>
>> Also, move the xtal-clk node to restore alphabetical ordering.
> 
> Please send a separate patch for that
> 

Thanks for your review, I will add a new patch.

>>
>> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
>> ---
>>   .../dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts  | 30 ++++++++++++
>> +++++-----
>>   1 file changed, 23 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-
>> vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
>> index 69d6118ba57e7..c41525a34b721 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
>> @@ -45,13 +45,6 @@ secmon_reserved_bl32: secmon@5300000 {
>>           };
>>       };
>>   -    xtal: xtal-clk {
>> -        compatible = "fixed-clock";
>> -        clock-frequency = <24000000>;
>> -        clock-output-names = "xtal";
>> -        #clock-cells = <0>;
>> -    };
>> -
>>       dc_in: regulator-dc-in {
>>           compatible = "regulator-fixed";
>>           regulator-name = "DC_IN";
>> @@ -60,6 +53,16 @@ dc_in: regulator-dc-in {
>>           regulator-always-on;
>>       };
>>   +    pwm-leds {
>> +        compatible = "pwm-leds";
>> +
>> +        status {
>> +            linux,default-trigger="heartbeat";
>> +            max-brightness = <255>;
>> +            pwms = <&pwm_ao_cd 0 30040 0>;
>> +        };
>> +    };
>> +
>>       sd_3v3: regulator-sdcard-3v3 {
>>           compatible = "regulator-fixed";
>>           regulator-name = "SD_3V3";
>> @@ -155,6 +158,13 @@ wifi32k: wifi32k {
>>           clock-frequency = <32768>;
>>               pwms = <&pwm_ab 0 30518 0>;
>>       };
>> +
>> +    xtal: xtal-clk {
>> +        compatible = "fixed-clock";
>> +        clock-frequency = <24000000>;
>> +        clock-output-names = "xtal";
>> +        #clock-cells = <0>;
>> +    };
>>   };
>>     &pwm_ab {
>> @@ -163,6 +173,12 @@ &pwm_ab {
>>       pinctrl-names = "default";
>>   };
>>   +&pwm_ao_cd {
>> +    status = "okay";
>> +    pinctrl-0 = <&pwm_ao_c_d_pins>;
>> +    pinctrl-names = "default";
>> +};
>> +
>>   /* SDIO */
>>   &sd_emmc_a {
>>       status = "okay";
>>
> 


-- 
Best regards,
Ronald