From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C3D4C10F14 for ; Tue, 15 Oct 2019 20:32:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A06020663 for ; Tue, 15 Oct 2019 20:32:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XcMifY8Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A06020663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hCEQjKsv/EWO9/VgW1hUbMwZ1ey+ZxQD9yDJh+Wzqp8=; b=XcMifY8ZwdTBHq EtOKf/KGZuqncIgkP5YY0RDRyFjF4V6Xwode297MkuXWcSLkix6X5LzRgUDYTbS24lTNVR0bezamR utpTJrC+wfeIG2qeSxbSjLraRX7Oy7dHZ1P51Fm887G2lbYn1oG3+uSX7772jKaB+blNwrzFMwMKQ Tw5OaySlM1lYCusCWb+VAap7CFrfxuKc53YPTmueJHH7UNbyiQpNnE0NCj/py0EluqSd1bhYKB7XH aSPmD6Emx7O9c4/e7Uiw9AZWrjIgVTGfS1N4gLG7oPwZtC1ljE5AEU2aS6J9RjgsASxiWHzH7dXJx JzwUlhMWf1cCOhMmRB4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKTUn-0007yK-Mf; Tue, 15 Oct 2019 20:32:41 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKTUk-0007xT-Es; Tue, 15 Oct 2019 20:32:39 +0000 Received: from remote.shanghaihotelholland.com ([46.44.148.63] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKTUh-00087j-Uz; Tue, 15 Oct 2019 22:32:35 +0200 From: Heiko Stuebner To: Johan Jonker Subject: Re: [PATCH 2/2] include: dt-bindings: rockchip: remove RK_FUNC defines Date: Tue, 15 Oct 2019 22:32:30 +0200 Message-ID: <2623685.EsipSBtvXi@phil> In-Reply-To: <29be43a3-516b-ce33-8a19-ffd8202d9c3a@gmail.com> References: <20191015191000.2890-1-jbx6244@gmail.com> <2236841.lnJlJmhppS@phil> <29be43a3-516b-ce33-8a19-ffd8202d9c3a@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_133238_651123_341B6963 X-CRM114-Status: GOOD ( 13.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 15. Oktober 2019, 22:26:14 CEST schrieb Johan Jonker: > Hi Heiko, > > What's the plan for RK_FUNC_GPIO ? Change all to '0' or keep it? RK_FUNC_GPIO I'd like to keep :-) . Basic rationale is that mapping RK_FUNC_1 -> 1, RK_FUNC_2 -> 2, etc does not provide any additional value, while telling it explicitly that we're mapping to the gpio function does. Heiko > > On 10/15/19 10:10 PM, Heiko Stuebner wrote: > > Hi Johan, > > > > Am Dienstag, 15. Oktober 2019, 21:10:00 CEST schrieb Johan Jonker: > >> The defines RK_FUNC_1, RK_FUNC_2, RK_FUNC_3 and RK_FUNC_4 > >> are no longer used, so remove them to prevent > >> that someone start using them again. > > > > That won't work. Devicetree provides a slightly flexible promise of > > backwards compatibilty. So a new kernel should still work old devicetrees. > > (not exactly sure if this means dt-binaries and sources or only binaries) > > > > So while I think RK_FUNC_0-n should not be used anymore, we should > > probably just mark them as "deprecated" in a first step. > > > > > > Heiko > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel