From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61C1BC4321E for ; Wed, 30 Nov 2022 17:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8b4UsNv1fm0Jhi9Y8yzJOcg9ei9kKzeN+WF/4Azyj/A=; b=yt4GUxFLF5ePT+ ijkEaE1f1IShL1KhMMw1M2RMwSx2NmSNAQH/u3LMTriPlNSpT/8QUqViEdFjQeEf2GrNgCZgNX6Qq ymNIMw/DVprr0sB0A3PySdLHc4pyMYBZ4jCsi75cTzouN+1znWf2FUsmQpiT1iM2JSFmknT92mDzW +vu0pu8U94ijw3ezRAvrPcFuLdnxQ3wxK6ok+s1uRBLDiA3ab0ONTp+9aWouxPOr/fh/eJOU24E80 cEW+Eb/PCI6cW/j1hWCsaZA/8FmYdnBeSEXHorhpgU0rDWAOjIG2vcOQbL8XwO2U4mdlgcx298OTO 1/DgqrkAPdd+T7c4WlkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0Qhg-000uMO-Px; Wed, 30 Nov 2022 17:17:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0Qhb-000uIm-Lb for linux-arm-kernel@lists.infradead.org; Wed, 30 Nov 2022 17:16:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3885D6E; Wed, 30 Nov 2022 09:17:00 -0800 (PST) Received: from [10.1.197.38] (eglon.cambridge.arm.com [10.1.197.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 698EC3F73B; Wed, 30 Nov 2022 09:16:53 -0800 (PST) Message-ID: <262410b1-2587-6ff8-9a7e-d67d8b9404fc@arm.com> Date: Wed, 30 Nov 2022 17:16:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 29/38] arm64/sysreg: Convert ID_PFR0_EL1 to automatic generation Content-Language: en-GB To: Will Deacon , Mark Brown Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas References: <20221028165426.1707896-1-james.morse@arm.com> <20221028165426.1707896-30-james.morse@arm.com> <20221114150236.GA31141@willie-the-truck> From: James Morse In-Reply-To: <20221114150236.GA31141@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_091655_879252_E903E6B0 X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, On 14/11/2022 15:02, Will Deacon wrote: > On Fri, Oct 28, 2022 at 06:17:48PM +0100, Mark Brown wrote: >> On Fri, Oct 28, 2022 at 05:54:17PM +0100, James Morse wrote: >> >>> Convert ID_PFR0_EL1 to be automatically generated as per DDI0487I.a, >>> no functional changes. >> >>> +Enum 19:16 CSV2 >>> + 0b0000 IMP >>> + 0b0001 IMP >>> + 0b0010 CSV2p1 >>> +EndEnum >> >> Should 0b0000 not be something like UNDISCLOSED (DDI0487I.a says "The >> implementation does not disclose whether FEAT_CSV2 is implemented.")? Sure, >> (I'm vaugely surprised the compiler didn't moan about the redefinition >> of the constant.) > > I'm not fussed about the name, but the duplicate field definitely needs > fixing otherwise defconfig is really noisy: > > ./arch/arm64/include/generated/asm/sysreg-defs.h:42:9: warning: 'ID_PFR0_EL1_CSV2_IMP' macro redefined [-Wmacro-redefined] > #define ID_PFR0_EL1_CSV2_IMP UL(0b0001) > ^ > ./arch/arm64/include/generated/asm/sysreg-defs.h:41:9: note: previous definition is here > #define ID_PFR0_EL1_CSV2_IMP UL(0b0000) > ^ > > James -- please can you spin a v2 with this fixed? Yup, sorry. I made some totally trivial change from the RFC - then completely fouled up the rebase. Conflicts in this file are hilarious. Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel