On common struct clk in clock framework.

On common struct clk in clock framework.

[mind entropy]

Hi,

   I am reading through mini2440 code and trying to understand
clocking code. I am getting confused as to whether it uses the common
clocking framework. In
https://github.com/torvalds/linux/blob/master/arch/arm/plat-samsung/include/plat/clock.h#L42
they define a struct clk. Even in OMAP
(http://processors.wiki.ti.com/index.php/Clock_Framework_User_Guide#Software_Implementation)
they have a separate struct clk definition. In the common clocking
framework shouldn't they be using the common struct clk rather than
have their own versions of struct clk?

Thanks in advance.

On common struct clk in clock framework.

[Tomasz Figa]

Hi,

On Wednesday 03 of July 2013 19:05:03 mind entropy wrote:
> Hi,
> 
>    I am reading through mini2440 code and trying to understand
> clocking code. I am getting confused as to whether it uses the common
> clocking framework. In
> https://github.com/torvalds/linux/blob/master/arch/arm/plat-samsung/incl
> ude/plat/clock.h#L42 they define a struct clk. Even in OMAP
> (http://processors.wiki.ti.com/index.php/Clock_Framework_User_Guide#Soft
> ware_Implementation) they have a separate struct clk definition. In the
> common clocking framework shouldn't they be using the common struct clk
> rather than have their own versions of struct clk?

The examples you pointed are not using Common Clock Framework. See 
Documentation/clk.txt and drivers/clk/ for more information about CCF.

As for s3c24xx, CCF driver for the whole platform is already merged for 
Linux 3.11.

Best regards,
Tomasz

On common struct clk in clock framework.

[mind entropy]

On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>
> The examples you pointed are not using Common Clock Framework. See
> Documentation/clk.txt and drivers/clk/ for more information about CCF.
>
> As for s3c24xx, CCF driver for the whole platform is already merged for
> Linux 3.11.
>
> Best regards,
> Tomasz
>

Thanks TomasZ. I have gone through the docs and was quite confused. I
will have a look at the merge.

On common struct clk in clock framework.

[Mike Turquette]

On Wed, Jul 3, 2013 at 9:51 PM, mind entropy <mindentropy@gmail.com> wrote:
> On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>>
>> The examples you pointed are not using Common Clock Framework. See
>> Documentation/clk.txt and drivers/clk/ for more information about CCF.
>>
>> As for s3c24xx, CCF driver for the whole platform is already merged for
>> Linux 3.11.
>>
>> Best regards,
>> Tomasz
>>
>
> Thanks TomasZ. I have gone through the docs and was quite confused. I
> will have a look at the merge.

Any clock implementation that defines its own struct clk is a legacy
clock framework and is not using the common clock infrastructure.
Another hint is if you see a clock driver that includes
linux/clk-provider.h, this implies a clock driver that is using the
common clock framework.

Regards,
Mike

>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On common struct clk in clock framework.

[Tomasz Figa]

On Thursday 04 of July 2013 10:21:27 mind entropy wrote:
> On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com> 
wrote:
> > The examples you pointed are not using Common Clock Framework. See
> > Documentation/clk.txt and drivers/clk/ for more information about CCF.
> > 
> > As for s3c24xx, CCF driver for the whole platform is already merged for
> > Linux 3.11.
> > 
> > Best regards,
> > Tomasz
> 
> Thanks TomasZ. I have gone through the docs and was quite confused. I
> will have a look at the merge.

Oops. It seems like s3c24xx clk driver is not merged yet. I don't know why 
I thought it is. Heiko (on CC) has been working on it and I remember seeing 
some patches from him. Sorry for misinformation.

Best regards,
Tomasz

> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On common struct clk in clock framework.

[Heiko Stübner]

Hi,

Am Donnerstag, 4. Juli 2013, 12:32:26 schrieb Tomasz Figa:
> On Thursday 04 of July 2013 10:21:27 mind entropy wrote:
> > On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com>
> 
> wrote:
> > > The examples you pointed are not using Common Clock Framework. See
> > > Documentation/clk.txt and drivers/clk/ for more information about CCF.
> > > 
> > > As for s3c24xx, CCF driver for the whole platform is already merged for
> > > Linux 3.11.
> > > 
> > > Best regards,
> > > Tomasz
> > 
> > Thanks TomasZ. I have gone through the docs and was quite confused. I
> > will have a look at the merge.
> 
> Oops. It seems like s3c24xx clk driver is not merged yet. I don't know why
> I thought it is. Heiko (on CC) has been working on it and I remember seeing
> some patches from him. Sorry for misinformation.

the ccf conversion should be ready, but at the time I submitted them, the pwm 
rework [that got rid of the pwm-internal clocks] was still missing.

At some point in the threads I lost track of its state, did the pwm rework 
make it into 3.11 after all, or is it an early 3.12 change?


Heiko

On common struct clk in clock framework.

[Heiko Stübner]

Am Donnerstag, 4. Juli 2013, 12:58:48 schrieb Heiko St?bner:
> Hi,
> 
> Am Donnerstag, 4. Juli 2013, 12:32:26 schrieb Tomasz Figa:
> > On Thursday 04 of July 2013 10:21:27 mind entropy wrote:
> > > On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com>
> > 
> > wrote:
> > > > The examples you pointed are not using Common Clock Framework. See
> > > > Documentation/clk.txt and drivers/clk/ for more information about
> > > > CCF.
> > > > 
> > > > As for s3c24xx, CCF driver for the whole platform is already merged
> > > > for Linux 3.11.
> > > > 
> > > > Best regards,
> > > > Tomasz
> > > 
> > > Thanks TomasZ. I have gone through the docs and was quite confused. I
> > > will have a look at the merge.
> > 
> > Oops. It seems like s3c24xx clk driver is not merged yet. I don't know
> > why I thought it is. Heiko (on CC) has been working on it and I remember
> > seeing some patches from him. Sorry for misinformation.
> 
> the ccf conversion should be ready, but at the time I submitted them, the
> pwm rework [that got rid of the pwm-internal clocks] was still missing.
> 
> At some point in the threads I lost track of its state, did the pwm rework
> make it into 3.11 after all, or is it an early 3.12 change?

of course I forgot the most important thing :-)

There is a big red line between the clocks starting with the s3c2443 and the 
other s3c24xx before it - they have nearly nothing in common. The ccf driver I 
created [0] therefore only provides the clocks for s3c2443, s3c2416 and 
s3c2450, which are very similar.


Heiko

[0] http://patches.sntech.de/projects/linux-kernel/01_mailinglist/s3c2416-
common-clk/