From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: omap_hsmmc: don't print uninitialized variables
Date: Tue, 26 Jan 2016 16:18:25 +0100 [thread overview]
Message-ID: <26439572.8QBco8eDYu@wuerfel> (raw)
In-Reply-To: <56A78838.3050400@ti.com>
On Tuesday 26 January 2016 16:52:40 Peter Ujfalusi wrote:
> > @@ -2133,7 +2131,17 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
> >
> > omap_hsmmc_conf_bus_power(host);
> >
> > - if (!pdev->dev.of_node) {
> > + host->tx_chan = dma_request_slave_channel(&pdev->dev, "tx");
> > + host->rx_chan = dma_request_slave_channel(&pdev->dev, "rx");
> > + if (!host->tx_chan || !host->rx_chan) {
>
> While it is really unlikely that we are failing to get only one of the
> channels... It means anyway that the omap_hsmmc is not usable, but we will
> still try to get via legacy mode and there is a chance that we might get some
> channel.
>
> Too bad that I can not send the conversion to dma_request_chan() yet due to
> missing things in arch...
>
> It might be simpler to just remove the printout of the rx/tx_req from the
> dev_err() when reporting failed channel requests...
Fine with me too, I'll send that patch as well and let Ulf pick.
Arnd
prev parent reply other threads:[~2016-01-26 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:50 [PATCH] mmc: omap_hsmmc: don't print uninitialized variables Arnd Bergmann
2016-01-26 14:52 ` Peter Ujfalusi
2016-01-26 15:18 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26439572.8QBco8eDYu@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox