From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB46CEB64DC for ; Fri, 21 Jul 2023 08:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XxLvRuMUoLTRdfYb8RpeUGrBQlVdzjerJF/SD7VFYfg=; b=HENtDFWVNJ64Mf w6CYum6PigkqCJzM2/gyb6TD+KFLKxQV/1vw8Xc6KVR8aLy7yZcCQiooXcsNViwsLgaU6jmnk0b9D PLi2cjbj1GiihnXh53gsZX7sPLdJ17dx3CmSp28mdOlSJEcwcO78gheGEh8/qNBspdEEkr9RxhqAT 6KX66lRnovvhO+z2nK/DX76ugXbkSCsJHgO2jKJnl6Q2bNxO3LGfnpSDVOIv8eUnI1VsDqy/UQnlo tFnxKhUtXlNXCiN0x6wS3cqe/nxAcUpg0XpbSJavzt19TeGWpujUAm4XcWBWmPcFR5CkaZoyutmsF IHsiYP9vEa5Z1go5fruA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMlcY-00DOhd-20; Fri, 21 Jul 2023 08:36:18 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMlcV-00DOgs-0y for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2023 08:36:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1689928575; x=1721464575; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qscxoPZSRFlMdwz0omMr1+2f4St3n6ppordwMHd/tdI=; b=LxaHENDMLgv+jhlhJrhMwvVtVypoL7a6iD4w/3pJUdHdpmJGNxVP/lBf EvL/0xQaSl3CVfnsy0o6/sZao/9voX4fcxHklNbTG2nArZYdQ6vYtbNpm 4ntNEKOAHKKA1HNiZmBgqPQI+qkgGLW+Sjpo3kbyukit1jcvLqfVy+y/u leo72zlzGDlLxalCQt0uMOR/hyKYSX+x5+8cbvL64fAzY/WKdwVs7fED/ FOoFhmitpm7F/SEhvTow19LB6Jk+nkgGaYYU8JxKHFgFEhIJdthmS+Ox/ Rr1s5I/hg9YRJ1V8f7Cih1an1V63P04KejuTiX/FOXeqlEi3Tiv0OkeMt Q==; X-IronPort-AV: E=Sophos;i="6.01,220,1684792800"; d="scan'208";a="32048717" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 21 Jul 2023 10:36:12 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 9FCF4280078; Fri, 21 Jul 2023 10:36:12 +0200 (CEST) From: Alexander Stein To: Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam , Sebastian Reichel Cc: Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] drm/imx/ipuv-v3: Fix front porch adjustment upon hactive aligning Date: Fri, 21 Jul 2023 10:36:10 +0200 Message-ID: <2644832.X9hSmTKtgW@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230503111456.1748511-1-alexander.stein@ew.tq-group.com> References: <20230503111456.1748511-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_013615_642925_00E27028 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 3. Mai 2023, 13:14:56 CEST schrieb Alexander Stein: > When hactive is not aligned to 8 pixels, it is aligned accordingly and > hfront porch needs to be reduced the same amount. Unfortunately the front > porch is set to the difference rather than reducing it. There are some > Samsung TVs which can't cope with a front porch of instead of 70. > = > Fixes: 94dfec48fca7 ("drm/imx: Add 8 pixel alignment fix") > Signed-off-by: Alexander Stein > --- > AFAICS ipu_di_adjust_videomode() checks that front porch is big enough to > reduce the alignment difference. A gentle ping. Is there anything to do? Or is someone picking this patch wa= s = tested by Ian? Best regards, Alexander > drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c > b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c index 1d306f7be9fd..341e9125bf2c > 100644 > --- a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c > +++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c > @@ -311,7 +311,7 @@ static void ipu_crtc_mode_set_nofb(struct drm_crtc > *crtc) sig_cfg.mode.hactive, new_hactive); > = > dev_info(ipu_crtc->dev, "hfront_porch: %u\n", = sig_cfg.mode.hfront_porch); > - sig_cfg.mode.hfront_porch =3D new_hactive - = sig_cfg.mode.hactive; > + sig_cfg.mode.hfront_porch -=3D new_hactive - = sig_cfg.mode.hactive; > dev_info(ipu_crtc->dev, "hfront_porch: %u\n", sig_cfg.mode.hfront_porch); > sig_cfg.mode.hactive =3D new_hactive; > } -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel