From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88A6C433EF for ; Tue, 9 Nov 2021 17:31:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E7D661184 for ; Tue, 9 Nov 2021 17:31:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7E7D661184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=quicinc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i/W6yWC++DfzLteIvCaXdl1Fx4aIpXcOsfljhRmfdRw=; b=jyHIqzsMyXjAvd IxH9QO/4mbWMoUoM4D3WqM6U7RSCtshGPVRomt5jEcneODzV9tNJyGaVTSdkHy5I4Nj0H2FgCCp84 ptEwPQr81+Gw5E74B+jBeR1/XQG1S01rKFfXafKj/peDuTCoq+MAKrhwnTB3YPH2/FHLTItl5vE63 dMKy7/CGNE42onShNeKmpy1ZLojtgQYXaqq1+yrwD9AMhCosGI5VzRIhkGqmqQtYL2S/gAPO1BZfD WmCWMTtYmnVaCy3BNEhUlo1tNwwZLVSGJuQWRQct4oKSsNKCqiO+zrIT0KoLzVb5+kaqGoV9+2P7e pakfjJdyMZ1t+kqKUePg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkUxA-002tEl-KB; Tue, 09 Nov 2021 17:30:36 +0000 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkUx4-002tDN-G6 for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 17:30:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1636479030; x=1668015030; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=bUKfBTTjjlA9eFUhmWx/Hg6n+E40zgyh3j2DQSOIXpM=; b=kBk4054MESJkpAW/JTec3RQ+qsMmSCWFsS5uCN8LvQavDu9LnPOjvZ4Z qpk1qkTRu8YDpt8Gdlm+rMgyXhc0/us/QwAzv1bmiAZjVKC/YqcBsWLfH ASbtKD68ByYUvNE0UeUQTWHTx7F+oyitmNwS/r2zTNQjJtFEev9F4HUSE 0=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-02.qualcomm.com with ESMTP; 09 Nov 2021 09:30:23 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 09:30:23 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.7; Tue, 9 Nov 2021 09:30:21 -0800 Received: from [10.50.19.148] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.7; Tue, 9 Nov 2021 09:30:16 -0800 Message-ID: <264b77dd-5509-60f9-248c-a93135b01aa9@quicinc.com> Date: Tue, 9 Nov 2021 23:00:11 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCHv3 3/3] dynamic_debug: Add a flag for dynamic event tracing Content-Language: en-US To: Steven Rostedt CC: Will Deacon , Catalin Marinas , , Marc Zyngier , , , , , , , , References: <3706af20bc64a320ff8f3ff8950738b988f4bdf5.1636452784.git.quic_saipraka@quicinc.com> <20211109104941.2d50eafc@gandalf.local.home> <20211109115951.1c2b5228@gandalf.local.home> From: Sai Prakash Ranjan In-Reply-To: <20211109115951.1c2b5228@gandalf.local.home> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_093030_603555_3123B855 X-CRM114-Status: GOOD ( 20.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Steve, On 11/9/2021 10:29 PM, Steven Rostedt wrote: > On Tue, 9 Nov 2021 21:52:26 +0530 > Sai Prakash Ranjan wrote: > >>>> rwmmio_read: rpmh_rsc_probe+0x35c/0x410 readl addr=0xffff80001071000c >>>> rwmmio_read: rpmh_rsc_probe+0x3d0/0x410 readl addr=0xffff800010710004 >>>> rwmmio_write: rpmh_rsc_probe+0x3b0/0x410 writel addr=0xffff800010710d00 val=0x3 >>>> rwmmio_write: write_tcs_cmd+0x6c/0x78 writel addr=0xffff800010710d30 val=0x10108 >>> I'd much rather have a module name or something attached to the event that >>> ca be filtered on via the trace event filters, than having it determined by >>> some side effect done in another directory. >> I presume we don't have CALLER_MODULENAME0,1,2.. like CALLER_ADDR0,1,2 >> without which we >> cannot insert the module name to this trace event since MMIO accessors >> are defined in low level >> arch headers and we won't get any useful module information from where >> these accessors are >> called. The function name and the offset is good enough to identify the >> exact line and module after >> post-processing with tools like GDB, objdump, so I feel we can keep the >> trace event fields limited? > I'm thinking we can pass the descriptor to the event and not have it record > it. We could add a new field type for defining the event. Something like: > > __filter_field() > > that has size zero in the event itself, but is available to the filtering > logic. Than perhaps we could pass that descriptor to the filter that has > all the information needed. > > DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, width); > log_read_mmio(width, addr, descriptor); > > Where descriptor is NULL when dynamic debug in disabled. > > Have a way to pass that descriptor to the filtering logic (I'll have to > take a look into it) and then be able to use the normal filtering. > > This way you could also create multiple instances, where one instance > records the events coming from one file, and the other records events from > another file, and not have just one big switch that disables all calls to > log_read_mmio(). > > -- Steve Ah that's a very good idea, descriptor does contain the module, file name. We can probably even pass the module name,file name as string from the descriptor itself to event? Perhaps we can do that for all trace events and not just this trace event? Just like the trace event name displayed with trace events, perhaps have file name,module name displayed when dynamic debug is enabled? Filtering by filename is pretty useful since most of these usecases in debugging will be with respect to some driver or subsystems. Thanks, Sai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel