From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A3BFC433EF for ; Sat, 11 Dec 2021 10:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gd3CyCdpPkfzr4QiMu8ZILcnnJ5Mic4lh9xtA99yjFk=; b=Q6Wfme93KIOKpV KF7VcqlaX25uKz3BwyfBVFmsTaNvTyCYu3njxuDtn/q4dzrhWmPtCGtLTPqZZU7p5gZ2nY2WLQDtt UCfQzJVaBx9DvyOOQuH2dp1SXTBFgU7GXSdnLQTwAJzMTUIe+NMZUrZn3ncHNoCG0kF0KlNQ/azDi 76d9Cy6UlM7euv4/gue6zJsknQVv74L3q26OidKNhXfEWCLUlKcbppT97cjP3V4LdcqknplWlYITZ W+rqWk0ng5dOFGyauC7b3CVn9ovTihTDoJbEEzn3BBcB27QDZhXr/HkaFLj2qQ/2rbzj9g9v13Q3P hxN1AWMi/fbosjVmqTTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mw038-004ty4-AH; Sat, 11 Dec 2021 10:56:18 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mw034-004txP-Vm; Sat, 11 Dec 2021 10:56:16 +0000 Received: from ip4d17a2ab.dynamic.kabel-deutschland.de ([77.23.162.171] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mw02p-0007zm-NW; Sat, 11 Dec 2021 11:55:59 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sandy Huang , David Airlie , Daniel Vetter , Rob Herring , - , David Heidelberg Cc: ~okias/devicetree@lists.sr.ht, David Heidelberg , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI Date: Sat, 11 Dec 2021 11:55:58 +0100 Message-ID: <26502781.jAYDHVeSjN@diego> In-Reply-To: <20211206212651.126405-1-david@ixit.cz> References: <20211206212651.126405-1-david@ixit.cz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211211_025615_055350_F46D6840 X-CRM114-Status: GOOD ( 14.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David, Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg: > Convert into YAML format into format, which can be validated. > > Changes: > - drop panel from example the patch subject is strange, talking about a "power domain node". That needs a fix. Some more things below. > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - rockchip,px30-mipi-dsi > + - rockchip,rk3288-mipi-dsi > + - rockchip,rk3399-mipi-dsi > + - const: snps,dw-mipi-dsi > + - items: > + - const: rockchip,px30-mipi-dsi > + - items: > + - const: rockchip,rk3288-mipi-dsi > + - items: > + - const: rockchip,rk3399-mipi-dsi what are these for? I see that px30 uses the dsi without the snps part, but you can also just add a patch adding that second compatible to px30.dtsi I don't think we need to support both ways. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: true > + > + clock-names: true > + > + phys: > + maxItems: 1 > + description: The external PHY make that "Optional external PHY perhaps"? Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel