From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48284C52D7C for ; Fri, 23 Aug 2024 10:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v0LeMgJRYBg8K7wbk7ooT8pgvMH0myISlFP95cB3MbM=; b=xOcfDNG5jddC7f3Ndb2IyzJ1Xf Yg0XhgAfEksq2PDX0ztIpRfrPaNdvjh4fLH5GLEwmGaxT20RpZRcOMY0++DLaxe7t1ugKd8mIJm4V pWMdvK0sXtPg62x/itDgkLRDdviOjeV113SrBLiK4seoEd/hEcYlqYEMBXtsFtddfzLTHtlC14sE8 0K+orPkHWVCsr49kccsr6WHkcuur8nG54Con42Nt11Q8a1/28BDRKDkVClRs+LV5YzKA0unCBtVoY RG+EvnNzzuJRJ+f+TN3CJIVzHjmgZddAwAZcDyau0bJmyAXAM+S5EmTr2BfE9I5NQfv/Hc7ff8S5Q +CXw6ffA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shRgq-0000000GMxf-0HAY; Fri, 23 Aug 2024 10:38:44 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shRg4-0000000GMrr-3aNE for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 10:37:58 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2f3f0bdbcd9so19116721fa.1 for ; Fri, 23 Aug 2024 03:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724409475; x=1725014275; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=v0LeMgJRYBg8K7wbk7ooT8pgvMH0myISlFP95cB3MbM=; b=XHBc1SkAJ/nvDA6nkxw2EkBLInn8QOP5J1JocvL2JwvpoKaI8+cPyD2Cme3DdaKs7I hV1e8soP/s9w7Kj+38RL8aZwkqMHCql2b+22dpJF2Kr6zW4soGWAhhrnwK6u8LMmfMjo 1URbiw5UOMtRB7fbkO93HPJnWF5F4dI8IRZBU+9xMG/M+GzZ8BsPke0qe29enITqNgAt lxEqHZ9lhem2+ZM/7a6fu1FOLILNp/kPbMdFuNK8KIretaHMzO/YcyHqM9YF493YNL8D eqYcF9kSA3H8VrvWyoGBuD8OtNjjuGtzSGONbpG06b8xnc8KRIVD/LkOnzh+xW35Q7Sk mvlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724409475; x=1725014275; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v0LeMgJRYBg8K7wbk7ooT8pgvMH0myISlFP95cB3MbM=; b=IVovSjMDl78JoKubJOykfwCYviRY7i/sj6RYXQ5Ptw32mrILmYFsusDh97MtWbZlBm gs2nKaxGmqr3+AoDphnIlliWxLlT80jMxiqcO7bEzhCQds0An6jeUWb6BFLV/ZWFumwz b4dvtHQx/YgbdkQq7QHpS1C1NunDfTEL59SYfzrcQoo44XpL3P4s+RfbsvWMRE8raRXm Ozk0TvLZl0xZ1ooKdDvbOS2KJyUt+46GIe7Rx2PNneZdYwQcKWx174A5lIoMqTxPgRAn ReiReO6LSCrkwYGatqc6VaSCSa3M8vwyDq7YEtCScnngfg3DmeSQ/MsSPgxB1r0/uQj+ TK1Q== X-Forwarded-Encrypted: i=1; AJvYcCUlXSNCqfxMrcw9WfGakDAXQh9FcCrIpnjx9MQ6bgZP0Mg3wFqGLIYR4PK9eSWYnnsS6XG5yrX3ltxKuRLN4LRV@lists.infradead.org X-Gm-Message-State: AOJu0YwvTzIFjTXAV0QC1djS5IvKkmL0CoppGVQRQ+VCFmGv2c0C2eiM L5fO2nkywTFCBkWBoICH7VwnchXa3t+4HhxJJ8LAI1ugYiwDP2A8GQxFWxQP6JM= X-Google-Smtp-Source: AGHT+IF67NWm5TQe0DotXe7LF2ieoS8iTeGL3Ai5V+Wj2UNvOtbNb0R/zaIf1oJOBecKsnnVv4h0JQ== X-Received: by 2002:a2e:bc08:0:b0:2ee:7a54:3b08 with SMTP id 38308e7fff4ca-2f4f48ec7d5mr14564141fa.3.1724409474311; Fri, 23 Aug 2024 03:37:54 -0700 (PDT) Received: from [192.168.1.3] ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c0515a945dsm1909462a12.94.2024.08.23.03.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 03:37:53 -0700 (PDT) Message-ID: <2654fbf8-0f1d-46c1-bfd4-936ef8982e19@linaro.org> Date: Fri, 23 Aug 2024 11:37:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf scripts python arm-cs-trace-disasm.py: Skip disasm if address continuity is broken From: James Clark To: Ganapatrao Kulkarni , Mike Leach Cc: Leo Yan , scclevenger@os.amperecomputing.com, acme@redhat.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, darren@os.amperecomputing.com, james.clark@arm.com, suzuki.poulose@arm.com, Al.Grant@arm.com References: <20240719092619.274730-1-gankulkarni@os.amperecomputing.com> <00fac24c-d664-4ebb-8c60-f4697b7f76c1@linaro.org> <8b53a424-19f7-4042-a2db-e1c5d051f9cc@os.amperecomputing.com> <6adf84fa-b755-4d7a-957a-9bf01e442238@linaro.org> <6f535bb6-2cee-48e6-93f1-ea19887bae74@os.amperecomputing.com> <027c76a9-9bd4-43e9-a170-8391a0037291@linaro.org> <3d7a6f93-0555-48fa-99cb-bf26b53c2da5@os.amperecomputing.com> <4dd7f210-c03e-4203-b8e9-1c26a7f8fe79@arm.com> <27912fc6-8419-4828-82a7-dacde5b4a759@linaro.org> <36f947ef-c2a7-486a-b905-f0529308b06e@linaro.org> <51661f76-c02a-49fb-8d68-53a8549acd19@os.amperecomputing.com> <279c7fae-efff-477e-8649-ff7f6d42dd87@linaro.org> Content-Language: en-US In-Reply-To: <279c7fae-efff-477e-8649-ff7f6d42dd87@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_033756_940403_C2663477 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/08/2024 11:36 am, James Clark wrote: > > > On 23/08/2024 10:57 am, Ganapatrao Kulkarni wrote: >> >> Hi James/Mike, >> >> On 23-08-2024 02:33 pm, James Clark wrote: >>> >>> >>> On 19/08/2024 11:59 am, Mike Leach wrote: >>>> Hi, >>>> >>>> A new branch of OpenCSD is available - ocsd-consistency-checks-1.5.4-rc1 >>>> >>>> Testing I managed to do confirms the N atom on unconditional branches >>>> appear to work. I do not have a test case for the range >>>> discontinuities. >>>> >>>> The checks are enabled using operation flags on decoder creation. See >>>> the docs for details. >>>> >>>> Mike >>>> >>> >>> Hi Mike, >>> >>> I tested the new OpenCSD and I don't see the error anymore in the >>> disassembly script. I'm not sure if we need to go any further and add >>> the backwards check, it looks like just a later symptom and the checks >>> that you've added already prevent it. >>> >>> If you release a new version I can send the perf patch. I was going to >>> use these flags if that looks right to you? As far as I know that's the >>> set that can be always on and won't fail on bad hardware? >>> >>> I also assumed that ETM4_OPFLG_PKTDEC_AA64_OPCODE_CHK can be given even >>> for etmv3 and it's just a nop? >>> >>> diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c >>> index e917985bbbe6..90967fd807e6 100644 >>> --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c >>> +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c >>> @@ -685,9 +685,14 @@ cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, >>>                  return 0; >>> >>>          if (d_params->operation == CS_ETM_OPERATION_DECODE) { >>> +               int decode_flags = OCSD_CREATE_FLG_FULL_DECODER; >>> +#ifdef OCSD_OPFLG_N_UNCOND_DIR_BR_CHK >>> +               decode_flags |= OCSD_OPFLG_N_UNCOND_DIR_BR_CHK | OCSD_OPFLG_CHK_RANGE_CONTINUE | >>> +                               ETM4_OPFLG_PKTDEC_AA64_OPCODE_CHK; >>> +#endif >>>                  if (ocsd_dt_create_decoder(decoder->dcd_tree, >>>                                             decoder->decoder_name, >>> -                                          OCSD_CREATE_FLG_FULL_DECODER, >>> +                                          decode_flags, >>>                                             trace_config, &csid)) >>>                          return -1; >>> >> >> I tried Mike's branch with above James's patch and still the segfault is happening to us. >> > > Did you update OpenCSD as well? > Oh sorry I only read the second part I see you did. Can you share your perf.data file? And do you see any of the new warnings: DCD_ETMV4_0018 : 0x002e (OCSD_ERR_BAD_DECODE_IMAGE) [Mismatch between trace packets and decode image.]; TrcIdx=3059; CS ID=12; Bad program image - N Atom on unconditional direct BR.