From: "Heiko Stübner" <heiko@sntech.de>
To: Diederik de Haas <didi.debian@cknow.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Dragan Simic <dsimic@manjaro.org>,
Maximilian Weigand <mweigand@mweigand.net>,
Marek Kraus <gamiee@pine64.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote
Date: Mon, 10 Feb 2025 13:06:14 +0100 [thread overview]
Message-ID: <2663295.taCxCBeP46@diego> (raw)
In-Reply-To: <87a29b78-5fab-48eb-9a86-f12c41369dfa@kernel.org>
Am Montag, 10. Februar 2025, 12:06:15 MEZ schrieb Krzysztof Kozlowski:
> On 07/02/2025 12:11, Diederik de Haas wrote:
> > Add the recommended chassis-type root node property so userspace can
> > request the form factor and adjust their behavior accordingly.
> >
> > Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
> > Link: https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
>
> Drop link, no need to point to source of every property. You don't do it
> for aliases, compatible, model etc, right?
>
> With link dropped:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I've amended the patch [0] by dropping the Link and adding Krzysztof's
Reviewed-by.
Heiko
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=aba881f30e0294a58c0cb076918d366e39801185
next prev parent reply other threads:[~2025-02-10 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 11:11 [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote Diederik de Haas
2025-02-07 15:01 ` Dragan Simic
2025-02-07 16:39 ` Diederik de Haas
2025-02-07 17:12 ` Dragan Simic
2025-02-10 10:39 ` Heiko Stuebner
2025-02-10 11:06 ` Krzysztof Kozlowski
2025-02-10 12:06 ` Heiko Stübner [this message]
2025-02-10 12:47 ` Diederik de Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2663295.taCxCBeP46@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=dsimic@manjaro.org \
--cc=gamiee@pine64.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mweigand@mweigand.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).