[PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Diederik de Haas]

Add the recommended chassis-type root node property so userspace can
request the form factor and adjust their behavior accordingly.

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
Link: https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
---
 arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
index 2d3ae1544822..3613661417b2 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
@@ -9,6 +9,8 @@
 #include "rk3566.dtsi"
 
 / {
+	chassis-type = "tablet";
+
 	aliases {
 		mmc0 = &sdhci;
 	};
-- 
2.47.2

Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Dragan Simic]

Hello Diederik,

On 2025-02-07 12:11, Diederik de Haas wrote:
> Add the recommended chassis-type root node property so userspace can
> request the form factor and adjust their behavior accordingly.
> 
> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
> Link: 
> https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node

Maybe the Link tag should be converted into a "[1]" reference?
To me, this is more like a reference for this DT addition.

In general, references can also be placed closer to the contents
they back up, which isn't possible with Link tags, but of course
that doesn't matter much in this case.

> ---
>  arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> index 2d3ae1544822..3613661417b2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> @@ -9,6 +9,8 @@
>  #include "rk3566.dtsi"
> 
>  / {
> +	chassis-type = "tablet";
> +
>  	aliases {
>  		mmc0 = &sdhci;
>  	};

The patch is obviously fine.  Thanks for the patch, and please feel
free to include, regardless of the note above, my:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

Hi Dragan,

On Fri Feb 7, 2025 at 4:01 PM CET, Dragan Simic wrote:
> On 2025-02-07 12:11, Diederik de Haas wrote:
>> Add the recommended chassis-type root node property so userspace can
>> request the form factor and adjust their behavior accordingly.
>> 
>> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
>> Link: 
>> https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
>
> Maybe the Link tag should be converted into a "[1]" reference?
> To me, this is more like a reference for this DT addition.
>
> In general, references can also be placed closer to the contents
> they back up, which isn't possible with Link tags, but of course
> that doesn't matter much in this case.

I generally use the "[1]" format when linking to specific claims, which
I could've done wrt the "recommended". But I considered this a general
background link and then I prefer to do it via a Link tag.

If requested by a maintainer I'll change it ofc, but otherwise I prefer
to keep it as is.

>> ---
>>  arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
>> index 2d3ae1544822..3613661417b2 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
>> @@ -9,6 +9,8 @@
>>  #include "rk3566.dtsi"
>> 
>>  / {
>> +	chassis-type = "tablet";
>> +
>>  	aliases {
>>  		mmc0 = &sdhci;
>>  	};
>
> The patch is obviously fine.  Thanks for the patch, and please feel
> free to include, regardless of the note above, my:
>
> Reviewed-by: Dragan Simic <dsimic@manjaro.org>

Thanks :)

Cheers,
  Diederik

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Dragan Simic]

On 2025-02-07 17:39, Diederik de Haas wrote:
> On Fri Feb 7, 2025 at 4:01 PM CET, Dragan Simic wrote:
>> On 2025-02-07 12:11, Diederik de Haas wrote:
>>> Add the recommended chassis-type root node property so userspace can
>>> request the form factor and adjust their behavior accordingly.
>>> 
>>> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
>>> Link:
>>> https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
>> 
>> Maybe the Link tag should be converted into a "[1]" reference?
>> To me, this is more like a reference for this DT addition.
>> 
>> In general, references can also be placed closer to the contents
>> they back up, which isn't possible with Link tags, but of course
>> that doesn't matter much in this case.
> 
> I generally use the "[1]" format when linking to specific claims, which
> I could've done wrt the "recommended". But I considered this a general
> background link and then I prefer to do it via a Link tag.
> 
> If requested by a maintainer I'll change it ofc, but otherwise I prefer
> to keep it as is.

Indeed, in this case it's pretty much irrelevant which format is used.
In fact, it may look nicer to use a Link tag, because there are only
a few lines in the patch description in total. :)

My comment was more about longer commit/patch descriptions with multiple
references, which should benefit from placing references closer to the
backed-up contents using the "[*]" layout, instead of relying on Link
tags to bunch it all together at the end of the description.

Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Heiko Stuebner]

On Fri, 07 Feb 2025 12:11:39 +0100, Diederik de Haas wrote:
> Add the recommended chassis-type root node property so userspace can
> request the form factor and adjust their behavior accordingly.
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: add 'chassis-type' property on PineNote
      commit: 18cb5cb58f4fcbd96d00e1d882e6b5882d1b272f

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Krzysztof Kozlowski]

On 07/02/2025 12:11, Diederik de Haas wrote:
> Add the recommended chassis-type root node property so userspace can
> request the form factor and adjust their behavior accordingly.
> 
> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
> Link: https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node

Drop link, no need to point to source of every property. You don't do it
for aliases, compatible, model etc, right?

With link dropped:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Heiko Stübner]

Am Montag, 10. Februar 2025, 12:06:15 MEZ schrieb Krzysztof Kozlowski:
> On 07/02/2025 12:11, Diederik de Haas wrote:
> > Add the recommended chassis-type root node property so userspace can
> > request the form factor and adjust their behavior accordingly.
> > 
> > Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
> > Link: https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
> 
> Drop link, no need to point to source of every property. You don't do it
> for aliases, compatible, model etc, right?
> 
> With link dropped:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I've amended the patch [0] by dropping the Link and adding Krzysztof's
Reviewed-by.


Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=aba881f30e0294a58c0cb076918d366e39801185

Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

On Mon Feb 10, 2025 at 12:06 PM CET, Krzysztof Kozlowski wrote:
> On 07/02/2025 12:11, Diederik de Haas wrote:
>> Add the recommended chassis-type root node property so userspace can
>> request the form factor and adjust their behavior accordingly.
>> 
>> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
>> Link: https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
>
> Drop link, no need to point to source of every property. You don't do it
> for aliases, compatible, model etc, right?

Thanks for that hint, I'll keep that in mind for next time :-)

Cheers,
  Diederik

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]