Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Russell King <linux@armlinux.org.uk>, jbx6244@gmail.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Hüseyin BIYIK" <boogiepop@gmx.com>,
	"Johan Jonker" <jbx6244@gmail.com>
Subject: Re: [PATCH] ARM: rockchip: smp: enable CPU1 for rk3066a
Date: Sat, 29 Aug 2026 23:59:55 +0200	[thread overview]
Message-ID: <2667576.VLH7GnMWUR@diego> (raw)
In-Reply-To: <20260829-cpu-v1-1-33dca576db92@gmail.com>

Am Samstag, 29. August 2026, 01:40:57 Mitteleuropäische Sommerzeit schrieb Johan Jonker via B4 Relay:
> From: Hüseyin BIYIK <boogiepop@gmx.com>
> 
> RK3066a CPU1 fails to come online. Fix by using
> a similar mailbox construction as in use with
> other Rockchip SoCs.

"RK3066 CPU1 fails to come online with recent kernels....[rest]" or so
and also please use the line length up a resonable length like around 70
to 75 characters.

Also, is it known, why that happens - i.e. what changed?

> Signed-off-by: Hüseyin BIYIK <boogiepop@gmx.com>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  arch/arm/mach-rockchip/platsmp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
> index f659d894bfae..d7d080c29f3c 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -133,7 +133,8 @@ static int rockchip_boot_secondary(unsigned int cpu, struct task_struct *idle)
>  	if (ret < 0)
>  		return ret;
>  
> -	if (read_cpuid_part() != ARM_CPU_PART_CORTEX_A9) {
> +	if (read_cpuid_part() != ARM_CPU_PART_CORTEX_A9 ||
> +	    of_machine_is_compatible("rockchip,rk3066a")) {
>  		/*
>  		 * We communicate with the bootrom to active the cpus other
>  		 * than cpu0, after a blob of initialize code, they will

isn't now the only user of the old system the RK3188?

With both rk3066 and rk3188 from a similar time, I'd assume both could
be switch and thus the the now unused code removed?

I've never thought to look into that ... need to find my RK3188 board :-)


Heiko




      reply	other threads:[~2026-08-29 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 23:40 [PATCH] ARM: rockchip: smp: enable CPU1 for rk3066a Johan Jonker via B4 Relay
2026-08-29 21:59 ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2667576.VLH7GnMWUR@diego \
    --to=heiko@sntech.de \
    --cc=boogiepop@gmx.com \
    --cc=jbx6244@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox