From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A9E3C6FD1D for ; Tue, 4 Apr 2023 16:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GeYW7V9jJccPjRfGfZR6ES7SJypBvb86Arnr65Z/AD8=; b=u1kNfNNyfBfFBc nwZm0egXFXaSoWTk2yKvI6NQU6Q9HzT/g6CKUL5xw+/xFR2RuIGECsCWZNnD+6njKCUfty6hx6k1s lPWCmN+IVC4Q5teFJHtpS3Y2r4JXQpekMZOsj59hmXGMIjve8fSOZDJuMEvbegSM3HhN29u6Crht9 OdlDZZa0BmZyZ9n5sbYKdbVhiRNWFZU+t3BLH5WinIKtF3AcYi8fXm/ezomU7reQNZKzJeYvyLTt1 zwLppEodFWBABbng/CG1pqWFgirmhZg3eL4JEiOFybLANReOxXx1yzH2S0Eef5TPgZZRqKQ3usrrK jzl2JmvwXCyirYhgv4Ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjjv5-002HXQ-07; Tue, 04 Apr 2023 16:54:07 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjjv2-002HVc-1c for linux-arm-kernel@lists.infradead.org; Tue, 04 Apr 2023 16:54:05 +0000 Received: by mail-ed1-x52f.google.com with SMTP id eh3so133206696edb.11 for ; Tue, 04 Apr 2023 09:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680627240; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sGzZwlArkCanfjz3209OKEfk0hXSgBO1tQBC1EAfOQs=; b=RtSnDTr1VANEwCyMGM+vEm53Kdt9EoAiFNvRS2f4emGqMqIA7o3Ois6LHXR1pKkb9G a7CSUA7lswHy8kM/nTNSDAMRVV6bjG7f8+6RKyYWETlq+PiUU/Gb2Js9uNu0c/gSg+Xj dM1SCz1cPMmNOdc+N3jVPfcwjkx7O+vDTt+8WIJKdZzOd3DjwpE7kRVeTSdPF/c3Y0ga KO82tzmJaW4G7KOADVI37ICZ6gxdYOZp1Elir/OFa0uXinSne8pQEmu4IzwZy/1wPZcm VlJe/8i6chRPUUJnNgs66kPhEAT0kXC0hulAm9ZAqj9+66UZJNLV9M/ySsdgxbvxOGUH 0vJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680627240; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sGzZwlArkCanfjz3209OKEfk0hXSgBO1tQBC1EAfOQs=; b=kmRyi+6APoN+J98gJkkekwKjS5jumMlhYCWAuyI4SWPYCZ9LhkWKLGOEePtYGOP9nU PTwx57I9ngqJzybwKoEjsZOlB2+zD124+CR86OaQmmPVg8U0hpTJHFY8fDIpOV9T9b/R nmx3tup8QaZzLCZ1ujMPzIDzWO3XnbXHhLMc+bQIM0F9Afhe4VqZqG7jD7ri1JugOrFz GzgGHcTMu0Er5/JjqtuD4DyZeTtotL4siZeODSfjk2YYbBSzkA3A+g+kZGoOO5CVn0Pu 7BM+BTVhxXzpUoaywsx3HWSnp8WiPz/HPKAQHPpKg2Uf/uk6OBpJfVWjzUf5K/++czYo vPug== X-Gm-Message-State: AAQBX9fL1KhDSRmcL06+kvUxdVT2ILR7LMIXgoXfgcLBEk4bglWxNuV7 x2vRfyGMhgf3zmnHhEbcMfs= X-Google-Smtp-Source: AKy350ZKXk3hfK516A/weJLnTJBSMLsovyookq63ehsy6W9OCLNvhirELuhDUofyxwVNkDU2Gor1fQ== X-Received: by 2002:a17:906:c784:b0:92d:591f:6586 with SMTP id cw4-20020a170906c78400b0092d591f6586mr220041ejb.34.1680627239992; Tue, 04 Apr 2023 09:53:59 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id k26-20020a1709062a5a00b009331450d04esm6284487eje.178.2023.04.04.09.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 09:53:59 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 15/24] staging: media: sunxi: cedrus: Convert to platform remove callback returning void Date: Tue, 04 Apr 2023 18:53:58 +0200 Message-ID: <2673737.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20230403154014.2564054-16-u.kleine-koenig@pengutronix.de> References: <20230403154014.2564054-1-u.kleine-koenig@pengutronix.de> <20230403154014.2564054-16-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_095404_536308_4AF0C4CF X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 03. april 2023 ob 17:40:05 CEST je Uwe Kleine-K=F6nig = napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel