From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09D0EC76188 for ; Wed, 5 Apr 2023 15:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m+EgNbJ14LhqASxkvnRO7K+pxGpMmr2KbyH2t8txXLc=; b=X3DmrGXPZsW5SI vCbGQzVoB84sfc22UorFaDU5qXcS5W9UnADom2nSC+aTSuF6sJtVsY7gQLLlBjZ8jsYiQ+P9/JeLW RfOOu2hF20cRPsyp+rTT/k7B1FZFQbpDTeRNK/2SjiButNUjkmmFIq5CINmmEUPOs1sFfep+xXpCY QpLifQz9ZzhA6mQKBZQCW02zCSDAxC0xylEUEYEyHMy42ERRUfNdleHGfniAbrjsZfwQ309h1eRKK HQOlpJpIGnuXcRkSgHUtOWByrteXn02OiQCujfkXIHw/cbCGrPR6S8tL5vkQdGn8vfP3D67BiK8gm E5SMi8W2bfCXM2izYcNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pk5IU-004vVW-36; Wed, 05 Apr 2023 15:43:42 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pk5HB-004u6f-2h for linux-arm-kernel@lists.infradead.org; Wed, 05 Apr 2023 15:42:26 +0000 Received: by mail-ed1-x534.google.com with SMTP id b20so142157125edd.1 for ; Wed, 05 Apr 2023 08:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680709332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W3rEjEBIzvTLM76lijFumhUVHcnIxOg2kiFST3j5p5o=; b=j0YrqLl8ikrtYvR4+5TGcOG3lc77ztC3YxP5gQBq9siJtXfCwggpjAkRS8aLC9F43d rSQfXBM1OZU6sTEseTUVbDj2JJWn1aDs5mYge6bdEXoiCRc/QojFSLK61m2/8oXnJCb+ 5DndmQfMph/b67yqiB8Gkg1xL7KC1E7QGiRdfdHUDugptIJ4RQl1CEfTdGxQGJRMMVqK o1e+C/Xv7HkySyEQ8sAu77H2vQwP5ohM8X+SK6xcd9UG+Yc6rbpafDhPmt1hwirNcwth kPNsZesw4mHFJDVHDXqCI+o6yg+QmvENnkeFbHVJLwQ/UN4/gp6nsRu07bPJBhhc2/8G N4/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680709332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W3rEjEBIzvTLM76lijFumhUVHcnIxOg2kiFST3j5p5o=; b=vO/DrPZXDAkULtOKj4QKOMNf2dq6RLLEBYPHefaY6Q6tHZnKQ/XvN7VSFkexqcQXEH L8hvFRQwrFa+6z8GTDUJT2nFu/8RgPQxFuIQhuXm/7cXIa01SKyNtPm75WFuwnekekMA 9l5gPeG69rmUUqPiVrDVsveIpeXtA0dIW31k+2mJRb6znL164WWbGJlmlyJchuyRO6vL Zg2IX4xaQJXEsxihsGAErDER82LpnoJkamGL9r4Aeyf/MlI7maeTOtQptcvmvpKBh+p8 gqgntlTLDWRw7sPTgyEhua4IFW/n/AEgqEEWYHavn1/x6GMC+nhBKZ5JbgMC1CqszWHH rf5A== X-Gm-Message-State: AAQBX9f/ZsMbnTxCxfLommFU4rwEy46PuurfM+zC/c+Hxj2kWvGm+Cxq qjwXrp7JblwAM92zt2fdHP4= X-Google-Smtp-Source: AKy350aN36e109j2V5e1/9ZUfUjDj2DnafFLoEuOLo0Bk2QvbJEJs80YfcFS2jjLPSNjlEG5VfvZDQ== X-Received: by 2002:a17:906:278e:b0:932:e43f:7367 with SMTP id j14-20020a170906278e00b00932e43f7367mr3619210ejc.35.1680709331933; Wed, 05 Apr 2023 08:42:11 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id jx10-20020a170906ca4a00b009495cfe446esm1174994ejb.223.2023.04.05.08.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 08:42:11 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Bin Liu , Greg Kroah-Hartman , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 08/10] usb: musb: sunxi: Convert to platform remove callback returning void Date: Wed, 05 Apr 2023 17:42:10 +0200 Message-ID: <2673762.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20230405141009.3400693-9-u.kleine-koenig@pengutronix.de> References: <20230405141009.3400693-1-u.kleine-koenig@pengutronix.de> <20230405141009.3400693-9-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230405_084221_933708_0D358039 X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 05. april 2023 ob 16:10:07 CEST je Uwe Kleine-K=F6nig napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel