Re: [PATCH] dt-bindings: arm: rockchip: Fix PCIe power enable pin for BTT CB2 and Pi2

["Heiko Stübner" <heiko@sntech.de>]

Hey Andrey,

Am Sonntag, 12. Oktober 2025, 11:31:26 Mitteleuropäische Sommerzeit schrieb Andrey Leonchikov:
> Fix typo into regulator GPIO definition. With current
> definition - PCIe don't up. Valid definition have on
> "pinctrl" section, "pcie_drv" (gpio4, RK_PB1).
> 
> Signed-off-by: Andrey Leonchikov <andreil499@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi | 2 +-

How did you decide on the patch subject?

I.e. "dt-binding: ..." denotes changes for the binding as the name implies,
while you change to a Rockchip specific Devicetree should have started with
"arm64: dts: rockchip: Fix PCIe ..."

Also, please provide a Fixes tag in the commit message.


Thanks
Heiko

>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> index 7f578c50b4ad..f74590af7e33 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> @@ -120,7 +120,7 @@ vcc3v3_pcie: regulator-vcc3v3-pcie {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vcc3v3_pcie";
>  		enable-active-high;
> -		gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;
> +		gpios = <&gpio4 RK_PB1 GPIO_ACTIVE_HIGH>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pcie_drv>;
>  		regulator-always-on;
>