From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, kernel@pengutronix.de
Subject: Re: [PATCH 46/49] mtd: rawnand: sunxi: Convert to platform remove callback returning void
Date: Sat, 01 Apr 2023 18:31:30 +0200 [thread overview]
Message-ID: <2676543.mvXUDI8C0e@jernej-laptop> (raw)
In-Reply-To: <20230401161938.2503204-47-u.kleine-koenig@pengutronix.de>
Dne sobota, 01. april 2023 ob 18:19:35 CEST je Uwe Kleine-König napisal(a):
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-04-01 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de>
2023-04-01 16:18 ` [PATCH 07/49] mtd: rawnand: atmel: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-03 8:37 ` Nicolas Ferre
2023-04-01 16:19 ` [PATCH 22/49] mtd: rawnand: lpc32xx_mlc: " Uwe Kleine-König
2023-04-01 16:19 ` [PATCH 23/49] mtd: rawnand: lpc32xx_slc: " Uwe Kleine-König
2023-04-01 16:19 ` [PATCH 25/49] mtd: rawnand: meson: " Uwe Kleine-König
2023-04-01 21:31 ` Martin Blumenstingl
2023-04-01 16:19 ` [PATCH 27/49] mtd: rawnand: mtk: " Uwe Kleine-König
2023-04-01 16:19 ` [PATCH 34/49] mtd: rawnand: oxnas: " Uwe Kleine-König
2023-04-01 16:19 ` [PATCH 40/49] mtd: rawnand: rockchip: " Uwe Kleine-König
2023-04-01 19:04 ` Heiko Stübner
2023-04-01 16:19 ` [PATCH 45/49] mtd: rawnand: stm32_fmc2: " Uwe Kleine-König
2023-04-01 16:19 ` [PATCH 46/49] mtd: rawnand: sunxi: " Uwe Kleine-König
2023-04-01 16:31 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2676543.mvXUDI8C0e@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=samuel@sholland.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox