From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B123C433E1 for ; Mon, 17 Aug 2020 12:53:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA1112078D for ; Mon, 17 Aug 2020 12:53:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pRGcpd1E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pUHLfV+s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA1112078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qjYSnzJhWc68YaYJPRko8oiLUsxngPWrdQFLDlWDQnA=; b=pRGcpd1EYHL7Ff1e1vgQfrt2g 0jqxwhdAEOJuwCmE1dNKNHAkMPLHIvy8bGBGozMhDMdBT0Btv+W/6DD4q9G6tDWg+wLq7ZZY4Gt4N 8ShgreF1UMwsWe427/db+cO01JB47yDlPONP1+TUtAyi0LU7ODL9CN/qWUIOH0tFZ3f+ThtMfukCs Zp/ucHX6F5cH96O9bRKQ6+dxMZthtMPx/F3Wx1vpQzwLua0S/V3sSfT1dGWViSRZT/w6tmvJspsbi 8+wSzkfKsrfxJYc0aXZGIHPKQT52mt74AQHWnQgO2LqcCNUfLjZN0QDM8ECp15ZCK1xh4Ew7diz+S b8qzCpEOw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7eca-0000kS-Bs; Mon, 17 Aug 2020 12:52:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7ecX-0000ja-L2 for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 12:52:14 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA53020789; Mon, 17 Aug 2020 12:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597668732; bh=LCkDhp0yrQ1H4GBGLsPDHG1MxDxVdl9KXyWjwLTvWPI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pUHLfV+s8fddXGPPQLHHqlb1z8AbfUZG7NYwsP6qnq5K2IVfcprGJsRrncpdFA9ra 0yWmrmbHicohobmmQJY+O/OkOVFL+9FwbcCNn8IymvQarItwreniFbq0rqYpjzwCEx WpS6O+f+OLhmp7XvP9Rx93u16E0rFw/5ea5eTJsA= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k7ecV-003ZH0-B9; Mon, 17 Aug 2020 13:52:11 +0100 MIME-Version: 1.0 Date: Mon, 17 Aug 2020 13:52:11 +0100 From: Marc Zyngier To: Keqian Zhu Subject: Re: [PATCH 1/2] clocksource: arm_arch_timer: Simplify and fix count reader code logic In-Reply-To: <20200817122415.6568-2-zhukeqian1@huawei.com> References: <20200817122415.6568-1-zhukeqian1@huawei.com> <20200817122415.6568-2-zhukeqian1@huawei.com> User-Agent: Roundcube Webmail/1.4.7 Message-ID: <267c5f9151c39fd2dcd0ce0b09d96545@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: zhukeqian1@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, steven.price@arm.com, drjones@redhat.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_085213_871735_0D69D6F7 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jones , kvm@vger.kernel.org, Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, Steven Price , James Morse , wanghaibin.wang@huawei.com, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-08-17 13:24, Keqian Zhu wrote: > In commit 0ea415390cd3 (clocksource/arm_arch_timer: Use > arch_timer_read_counter > to access stable counters), we separate stable and normal count reader. > Actually > the stable reader can correctly lead us to normal reader if we has no > workaround. Resulting in an unnecessary overhead on non-broken systems that can run without CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND. Not happening. > Besides, in erratum_set_next_event_tval_generic(), we use normal > reader, it is > obviously wrong, so just revert this commit to solve this problem by > the way. If you want to fix something, post a patch that does exactly that. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel