Re: [PATCH v7 29/36] drm/vc4: tests: Remove vc4_dummy_plane structure

Maxime Ripard
2024-02-28T16:17:07Z

[-- Attachment #1.1: Type: text/plain, Size: 1238 bytes --]

On Tue, Feb 27, 2024 at 07:45:01PM -0300, Maíra Canal wrote:
> Hi Maxime,
>
> On 2/27/24 10:02, Maxime Ripard wrote:
> > Hi Maíra,
> >
> > Thanks for you reviews!
> >
> > On Mon, Feb 26, 2024 at 09:29:32AM -0300, Maíra Canal wrote:
> > > On 2/22/24 15:14, Maxime Ripard wrote:
> > > > The vc4_dummy_plane structure is an exact equivalent to vc4_plane, so we
> > >
> > > Maybe I understood incorrectly, but isn't the vc4_dummy_plane structure
> > > equivalent to drm_plane?
> >
> > Both statements are true :)
> >
> > vc4 itself uses vc4_plane to holds its plane-related content, but it
> > turns out that there's nothing in that structure anymore and vc4_plane
> > == drm_plane.
> >
> > In our mock driver, we have another structure meant to store the
> > mock-plane-related content which doesn't have anything in it anymore,
> > and is thus equivalent to vc4_plane.
> >
> > So, basically, vc4_dummy_plane == vc4_plane == drm_plane.
> >
> > This patch is only about getting rid of vc4_dummy_plane though.
> >
> > Is it clearer?
> >
>
> Yeah, with that pointed out, you can add my:

I'll rephrase for the next version then

> Reviewed-by: Maíra Canal <mcanal@igalia.com>

Thanks!
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]