From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36369C54E58 for ; Fri, 15 Mar 2024 17:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NOFITRi4ipC4/z1BwO1FiqPdAqvSFwArk1rU+lD30PU=; b=kFr3xMturMZp0C sOjwakem4Nu55ok64HlT42NBtlUWvJiwQfJjTe3bAfwlI55DpzZ+r2VYG9L42ci3kKj4ab9MXxGo8 VZPVsCCSsuKGI+XvIN5TkQx8iEzLAElqNet3RwYa3pEYVke3YahHrVvctxAu9pnKJVzKybqa6xUH0 PKX/Tx5ETZV5es+SxiiXdOWGTeB9JKfdPSWZAEUtaXibYF2ZHstJeTBe9y6Bdq79WSKkLvZhsDf5y EJ5Qa52qlm1qlEAiaJDwE/Ow4/71z4g+Ha6Hn7zRGNYe0vy9s8TY1ZXSKxGtFH50onphP/IqRhLzD PeP1hTfQrRBJyK/yKQLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlBX2-000000012qF-12Tl; Fri, 15 Mar 2024 17:39:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlBWz-000000012pp-31Qx for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2024 17:39:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1B06361753; Fri, 15 Mar 2024 17:39:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2CE9C433F1; Fri, 15 Mar 2024 17:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710524383; bh=ai18tQCxEsVNBTB9pI+Y1iMrP4vEbIDkN2V9bYFwEuE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ThLdkbyJzeqXntUTQRuID6VAibZEXVYVFM6dB+1fOnSd27f+XnR829DJjeNBCm1j+ 9SpPaxsqxbCGOllpEII3ySsorrIjPgVrzX/wHagrArgmzxZhBRrcR2QwlhkoPceqUI tmu8/g40EV8XycRGpPwTZDBbFeuTzVCzjNo63LGo35FhcgwAea7oYoFMqF/iKbHXsf uv/pfWhvhEpCfbDqZi71Pxkh5qCKYEg4ug16RDXIQcOivHGLjbfLXsfX/gTn5AizNK hWhFRYYPTHaN1Sw5kG2pATuVECNppdHAicbCp3u1EG2B0vOBFJlwjW+PzY6dkZGARD GuECh3L6Y/4Mg== Message-ID: <2688272d2763a36f401a08ca48c0eb24.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <104401da76cc$ccc772c0$66565840$@samsung.com> References: <20240220084046.23786-1-shradha.t@samsung.com> <20240220084046.23786-2-shradha.t@samsung.com> <022301da6fbf$aae4f7e0$00aee7a0$@samsung.com> <9927a3356ce54c626ab4733844a4385b.sboyd@kernel.org> <104401da76cc$ccc772c0$66565840$@samsung.com> Subject: RE: [PATCH v6 1/2] clk: Provide managed helper to get and enable bulk clocks From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, mturquette@baylibre.com, jingoohan1@gmail.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux@armlinux.org.uk, m.szyprowski@samsung.com, manivannan.sadhasivam@linaro.org, pankaj.dubey@samsung.com, gost.dev@samsung.com To: 'Dan Carpenter' , Shradha Todi Date: Fri, 15 Mar 2024 10:39:41 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_103945_842462_C3298F2F X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Shradha Todi (2024-03-15 04:34:44) > > > > Quoting Shradha Todi (2024-03-06 04:13:03) > > > > > > > > When clk_bulk_get_all() returns zero then we return success here. > > > > > > > > > > Yes, we are returning success in case there are no clocks as well. In > > > case there are no clocks defined in the DT-node, then it is assumed > > > that the driver does not need any clock manipulation for driver > > > operation. So the intention here is to continue without throwing > > > error. > > > > Maybe we shouldn't even return the clks to the caller. Do you have any use for > > the clk pointers? > > The intention to return the clk pointers was in the case where caller wants to > manipulate a particular clock in certain conditions. They can obtain the clock pointer > and use clk_set_parent, clk_set_rate on those particular clocks. > But I understand that in that case users can use existing clk_bulk_get_all() API. > So, should I go ahead and send v7? > No, I think this is fine. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel