From: "Heiko Stübner" <heiko@sntech.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: florent.couzon@linaro.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: rock960 thermal zone returns EINVAL
Date: Thu, 07 Mar 2019 11:16:25 +0100 [thread overview]
Message-ID: <2690783.RMaZmsxJUM@diego> (raw)
In-Reply-To: <95fb869c-1fc0-f3f7-fd20-ddddeb490309@linaro.org>
Hi Daniel,
Am Donnerstag, 7. März 2019, 00:03:33 CET schrieb Daniel Lezcano:
> Hi Heiko,
>
> I just noticed the change is already there in your dev branch [1].
The patch from Ezequiel was actually in the 5.1-branch, so will make its
way into mainline with the arm-soc pull requests during this merge window.
Heiko
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/tre
> e/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi?h=v5.2-armsoc/dts64#n535
> On 06/03/2019 23:46, Daniel Lezcano wrote:
> > Hi Heiko,
> >
> > We ran the rock960 board with the v5.0 linux kernel and tried to read
> > the temperature of the thermal zones but that fails with an invalid
> > argument.
> >
> > It appears the sensor tsadc is disabled by default and if it is enabled,
> > it makes the board to reset at boot time.
> >
> > There are some extra configuration for the rk3399-puma.dts:
> >
> > &tsadc {
> >
> > rockchip,hw-tshut-mode = <1>;
> > rockchip,hw-tshut-polarity = <1>;
> > status = "okay";
> >
> > };
> >
> > or the rk3399-rockpro64.dts
> >
> > &tsadc {
> >
> > /* tshut mode 0:CRU 1:GPIO */
> > rockchip,hw-tshut-mode = <1>;
> > /* tshut polarity 0:LOW 1:HIGH */
> > rockchip,hw-tshut-polarity = <1>;
> > status = "okay";
> >
> > };
> >
> > I added the same change for the rk3399-rock.dts and I'm now able to
> > access the temperature of the different thermal-zones.
> >
> > Does it make sense to add this change for the rk3399-rock.dts?
> >
> > And is it acceptable to add for -rc ?
> >
> > Thanks
> >
> > -- Daniel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-07 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 22:46 rock960 thermal zone returns EINVAL Daniel Lezcano
2019-03-06 23:03 ` Daniel Lezcano
2019-03-07 10:16 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2690783.RMaZmsxJUM@diego \
--to=heiko@sntech.de \
--cc=daniel.lezcano@linaro.org \
--cc=florent.couzon@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox