From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA61C43381 for ; Thu, 7 Mar 2019 10:16:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A499320835 for ; Thu, 7 Mar 2019 10:16:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cd0Jr4u8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A499320835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FWJjukuR8VNa6CKUZlHjKC8pQjSSP/clqGhq/T2kT9E=; b=Cd0Jr4u8Lf6BxE dTWt+C0IVeHaX8r/LbY6VdPLNhAA4TCYO7oPAE0ognl056xqWeLlqpvH76QRj/ZEo/S9zRHHQVij4 S0fVfgsHJklRLoMZ8im0w++cgbpNgAUZwshPoq8G5vPO8Km7l/2IRTC7sgChQ9zkCT9fWzULtvs9D 7i/6Y9l23bzjJwhXjxqHbD+yxC2Othw6R0enWdog7iNnuSQaxCa7oVFKE2QbDYrH3eUsooLPKgz8L V3aKXtwDfSm7HyIa58ct17yP4QeHBz/ewMbzwb7U/AsJMMfLI9Fa9uv8zV1J1mmbVipvLUOi4qrKO uEr5vcHtqW4d64tUHpUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1q4o-0002Vq-ID; Thu, 07 Mar 2019 10:16:34 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1q4j-0002VG-VO for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2019 10:16:31 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h1q4f-0001gl-Tq; Thu, 07 Mar 2019 11:16:25 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Daniel Lezcano Subject: Re: rock960 thermal zone returns EINVAL Date: Thu, 07 Mar 2019 11:16:25 +0100 Message-ID: <2690783.RMaZmsxJUM@diego> In-Reply-To: <95fb869c-1fc0-f3f7-fd20-ddddeb490309@linaro.org> References: <95fb869c-1fc0-f3f7-fd20-ddddeb490309@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190307_021630_158951_989A949A X-CRM114-Status: GOOD ( 19.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: florent.couzon@linaro.org, "linux-arm-kernel@lists.infradead.org" , Manivannan Sadhasivam Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, Am Donnerstag, 7. M=E4rz 2019, 00:03:33 CET schrieb Daniel Lezcano: > Hi Heiko, > = > I just noticed the change is already there in your dev branch [1]. The patch from Ezequiel was actually in the 5.1-branch, so will make its way into mainline with the arm-soc pull requests during this merge window. Heiko > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/= tre > e/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi?h=3Dv5.2-armsoc/dts64#= n535 > On 06/03/2019 23:46, Daniel Lezcano wrote: > > Hi Heiko, > > = > > We ran the rock960 board with the v5.0 linux kernel and tried to read > > the temperature of the thermal zones but that fails with an invalid > > argument. > > = > > It appears the sensor tsadc is disabled by default and if it is enabled, > > it makes the board to reset at boot time. > > = > > There are some extra configuration for the rk3399-puma.dts: > > = > > &tsadc { > > = > > rockchip,hw-tshut-mode =3D <1>; > > rockchip,hw-tshut-polarity =3D <1>; > > status =3D "okay"; > > = > > }; > > = > > or the rk3399-rockpro64.dts > > = > > &tsadc { > > = > > /* tshut mode 0:CRU 1:GPIO */ > > rockchip,hw-tshut-mode =3D <1>; > > /* tshut polarity 0:LOW 1:HIGH */ > > rockchip,hw-tshut-polarity =3D <1>; > > status =3D "okay"; > > = > > }; > > = > > I added the same change for the rk3399-rock.dts and I'm now able to > > access the temperature of the different thermal-zones. > > = > > Does it make sense to add this change for the rk3399-rock.dts? > > = > > And is it acceptable to add for -rc ? > > = > > Thanks > > = > > -- Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel