public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: remove unused/deprecated read_cpuid_part_number()
Date: Tue, 05 Aug 2014 16:27:06 +0200	[thread overview]
Message-ID: <2694769.svrdKA2rqt@amdc1032> (raw)

Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part
number correctly") has left (now unused in the upstream tree and
marked as deprecated) read_cpuid_part_number() while changing
the way it works (using the old function with the definitions will
now always evaluate as false).  This causes problems with porting
older code to new kernels as the code compiles (with warnings but
they are very easy to miss) but it can fail silently or work just
fine depending on the used hardware.

Remove unused/deprecated read_cpuid_part_number() so developers
have to update their code during build time instead of running into
tricky runtime problems later.

Please see the commit af040ffc9ba1 for details on how to convert
your old out-of-tree code to use read_cpuid_part() instead of
read_cpuid_part_number().

Cc: Nicolas Pitre <nico@linaro.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 arch/arm/include/asm/cputype.h |    5 -----
 1 file changed, 5 deletions(-)

Index: b/arch/arm/include/asm/cputype.h
===================================================================
--- a/arch/arm/include/asm/cputype.h	2014-08-04 15:09:30.166988335 +0200
+++ b/arch/arm/include/asm/cputype.h	2014-08-05 15:40:03.793317783 +0200
@@ -182,11 +182,6 @@ static inline unsigned int __attribute_c
 	return read_cpuid_id() & 0xff00fff0;
 }
 
-static inline unsigned int __attribute_const__ __deprecated read_cpuid_part_number(void)
-{
-	return read_cpuid_id() & 0xFFF0;
-}
-
 static inline unsigned int __attribute_const__ xscale_cpu_arch_version(void)
 {
 	return read_cpuid_id() & ARM_CPU_XSCALE_ARCH_MASK;

             reply	other threads:[~2014-08-05 14:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 14:27 Bartlomiej Zolnierkiewicz [this message]
2014-08-05 16:29 ` [PATCH] ARM: remove unused/deprecated read_cpuid_part_number() Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2694769.svrdKA2rqt@amdc1032 \
    --to=b.zolnierkie@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox