linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: ux500: define serial port aliases
Date: Thu, 16 Jul 2015 16:09:42 +0200	[thread overview]
Message-ID: <2694937.qjRpGCMvqj@wuerfel> (raw)
In-Reply-To: <CACRpkdaL6DHChx7mSWiGk65LZNxkMGtw=aef2zyHaE7dDhXz8A@mail.gmail.com>

On Thursday 16 July 2015 16:03:18 Linus Walleij wrote:
> On Tue, Jul 14, 2015 at 10:53 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 13 July 2015 10:21:51 Linus Walleij wrote:
> >>
> >> Since the original code just defined all three serial ports
> >> for all boards by them including ste-dbx500.dtsi I first made
> >> the patch to that file, and then as you said it had to be done
> >> on a per-toplevel file, I did it in the individual DTS files instead.
> >
> > I'm not following here. If you have boards that want port 1 to be
> > disabled, shouldn't you remove that alias?
> 
> No, that is done by not changing status = "disabled"; to
> status = "okay"; on a per-board basis.
> 
> This is what the second patch is doing.
> 
> The aliases are set also to disabled ports to ensure enumeration
> for the cases where a board file enabled a previously disabled
> UART.
> 

Well, both really. The status property tells the kernel to not
ever touch a device, while the alias is what traditionally gets
used to assign an OS visible device name to a device in the tree.
This is more true for MacOS and AIX than Linux, which sometimes
does its own naming, but we really should not have an alias pointing
at a disabled device node.

	Arnd

  reply	other threads:[~2015-07-16 14:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10  9:32 [PATCH 1/2] ARM: ux500: define serial port aliases Linus Walleij
2015-07-12 21:02 ` Arnd Bergmann
2015-07-13  8:16   ` Linus Walleij
2015-07-13  8:21     ` Linus Walleij
2015-07-14 20:53       ` Arnd Bergmann
2015-07-16 14:03         ` Linus Walleij
2015-07-16 14:09           ` Arnd Bergmann [this message]
2015-07-16 19:57             ` Linus Walleij
2015-07-17 12:23               ` Arnd Bergmann
2015-07-14  9:15 ` Olof Johansson
  -- strict thread matches above, loose matches on Subject: below --
2015-07-08 13:15 Linus Walleij
2015-07-08 14:44 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2694937.qjRpGCMvqj@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).