public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] bridge: Elaborate a bit on dumb VGA bridges in Kconfig
Date: Wed, 28 Feb 2018 15:11:32 +0200	[thread overview]
Message-ID: <2696282.6cDKLY6rL2@avalon> (raw)
In-Reply-To: <20180228130249.22533-1-linus.walleij@linaro.org>

Hi Linus,

Thank you for the patch.

On Wednesday, 28 February 2018 15:02:49 EET Linus Walleij wrote:
> It's better if we explain a bit that this pertains to
> passive VGA DAC bridges.

s/passive/non-programmable/ ?

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Write that these bridges are non-programmable rather than
>   discrete, as that reflects the name of the bridge being
>   "dumb". Discrete is wrong as it has a specific electronic
>   meaning, as in "non-integrated" and this is integrated.

s/discrete/passive/ :-)

> ---
>  drivers/gpu/drm/bridge/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 3b99d5a06c16..e1ab948707a0 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -30,7 +30,8 @@ config DRM_DUMB_VGA_DAC
>  	depends on OF
>  	select DRM_KMS_HELPER
>  	help
> -	  Support for RGB to VGA DAC based bridges
> +	  Support for non-programmable RGB to VGA DAC based bridges
> +	  such as ADI ADV7123 or TI THS8134 and THS8135.

How about

"Support for non-programmable RGB to VGA DAC bridges, such as ADI ADV7123, TI 
THS8134 and THS8135 or passive resistor ladder DACs."

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  config DRM_LVDS_ENCODER
>  	tristate "Transparent parallel to LVDS encoder support"

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2018-02-28 13:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 13:02 [PATCH v2] bridge: Elaborate a bit on dumb VGA bridges in Kconfig Linus Walleij
2018-02-28 13:11 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2696282.6cDKLY6rL2@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox