From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D870BC433F5 for ; Mon, 25 Apr 2022 17:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=93922inh/Qx+xOzp7Q749A3w0P9sQpGFyt6UlE8FNp0=; b=p4/2A3ViiPLeAh RASSF3yIJ4o4JZi0+dWHGbWSuUpZ+P2/BigfhPkWxmjsJqzkcTIzs+0p9apzeirdlVzKvSdJ/uMTP HCN3oBFMywy14kQdle5gVRx4X7vyco0K3iqo/zmIhSWqSvLNd79hCStgB0z0pAx9MjP+an9Am3aS/ +z5OVhQlRUogVljRW5vQ5y207L/hi0UOzc2pFNAvq/zKOx2QOZ4PVrY1gF/O3Xu6+ZcSqHw8ROo0H J+aCjKaRHxr9mNoikXK3SREL/jiV69CmiJMbONQ0VuPwmD9mL6CNd8j/p3kklL85bsZXV0a/wjPbR L3BZ+qrj3jaFIcKAdYYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj2Yc-00Agkf-CX; Mon, 25 Apr 2022 17:31:30 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj2YX-00Agj2-9v for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 17:31:26 +0000 Received: by mail-ej1-x634.google.com with SMTP id l18so4385886ejc.7 for ; Mon, 25 Apr 2022 10:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Lx7n01ak613wao/PeGm56R/NraVbxP43cN5ZMlrScAY=; b=AWomtSHBSdpy50i/AiQTF1zEO67p6sM2bAacCXCIrE1EI3drNnFByVmoCM0R/JmKoO 9gRqHx/Jriy3h41XZP3C0mqTsYL8gZMgJtK5YGBcBAM13cfn2MrAbHZu+63WnkD3pA0M DlNSX4/BDpYDhYNLxlybbm4UpTRPqmYx6mc07No5+cFKexLhyMCE/gp0T9Y5ncFf9UlH 4t+iuhsW2AwBCXq8A0RuQ0hp4vsOhB/eDpAaHSKVH5lGxCZa6y2yaOCbBcLTm58dwi5j 2mokqtKMGMcjlCu7ZnzTM9o/NOIptNtADfUmrdCmKHoADrK3HZRdkAov3SEu1yD6nH7F 2pNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Lx7n01ak613wao/PeGm56R/NraVbxP43cN5ZMlrScAY=; b=N2Pq7bp1cGY3K/PBVsIyIFVukM1Pqms+hh6ukukGLqOVyo8um7OMBZJGa/e63sLlQI cdhlPei9PgoZHct+Hb5HH1ToBy1z8gEIdyKbVQhi8XQKmY7V0GJPoJN6E0uYRQ+crMab mBsCjBdz6D7apy3ZRC9Ni+hvI8ge0IY5kITvIdgGWVej8xkii1Wldiq8cd8zd1aDw3Qf FNIeZC0P4Vl06fZ0arkY/Leh5CimCsqn3N8gaDq7koATbzTmn4j01PRXEIrt48VxxaOl fXAwZimIgw0Sh3KXTGNF3PczQtBopg+rk3am9Cwa2/BAsi3qXwO8OfP+ZgZRvsHIFGYu 8T/A== X-Gm-Message-State: AOAM5335sMjXoN7hK0CJVGPMRLsMZeLcRtYeEc2OYE3uMKjvF86etKJP EESVL097gC45yxXmKJUIfKE= X-Google-Smtp-Source: ABdhPJxvwSr3XtyRkaaNJxbkUJVkHfpHdLP+s0Vc1yhmamJDJWKzG5omORC7vSs528rfOCd348xwnw== X-Received: by 2002:a17:907:6289:b0:6e0:eb0c:8ee7 with SMTP id nd9-20020a170907628900b006e0eb0c8ee7mr16442680ejc.245.1650907883149; Mon, 25 Apr 2022 10:31:23 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id r19-20020a17090638d300b006d6e4fc047bsm3884297ejd.11.2022.04.25.10.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 10:31:22 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Christophe JAILLET , Chen-Yu Tsai , Mark Brown , Maxime Ripard , Arnd Bergmann , Olof Johansson , Samuel Holland Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: Re: [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create() Date: Mon, 25 Apr 2022 19:31:21 +0200 Message-ID: <2699804.BEx9A2HvPv@kista> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_103125_397744_485FC368 X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sobota, 23. april 2022 ob 21:39:45 CEST je Samuel Holland napisal(a): > On 4/21/22 9:35 AM, Christophe JAILLET wrote: > > This code is really spurious. > > It always returns an ERR_PTR, even when err is known to be 0 and calls > > put_device() after a successful device_register() call. > > > > It is likely that the return statement in the normal path is missing. > > Add 'return rdev;' to fix it. > > Thanks for the patch. This definitely looks to be the case. > > > Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus") > > Signed-off-by: Christophe JAILLET > > Reviewed-by: Samuel Holland > Tested-by: Samuel Holland > Applied to sunxi/fixes-for-5.18, thanks! Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel