From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EEF5C4332F for ; Sat, 4 Nov 2023 11:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H7MSPnrrZsWW+qH1UU9uo9VPUkSlChHhZ2jCrQLPn2A=; b=rHy0LhzQc/4efV jFe/kRp3bB1/+vuQ6Psys1ai9lg1C1FvdHwhXm4n/ULGkxPkAFXSceoMapM1gv0QDT7qBIuRVGvyr e0r5ncfPULwLFTcGCEMk+LUofmO2glOld3Ruy7AUlMs+8tbvjESsqm5QUpzjp38vfbbUrfaRmDwmH LlWjQIlye+jZGOC6gkeMEh86Gs7t0ufDM3e0tZbDpqNdUtI85YKV0WgwE/HksLHTYORXMmgZ4ePe4 R0IwWH2/99VEoAQ69H17CCnylYXeNsXU2SiW6/ybhLz703uXZDJkduCRGq5m7uQNWYm7C45o5tICc UxiK/rg0Xy5IlYqr/i5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzErk-00DM47-2W; Sat, 04 Nov 2023 11:31:00 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzErh-00DM3O-0V for linux-arm-kernel@lists.infradead.org; Sat, 04 Nov 2023 11:30:58 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5409bc907edso4733570a12.0 for ; Sat, 04 Nov 2023 04:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699097455; x=1699702255; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ViIC/HSzRl49SaVz7Ic3OZfsB5CjZfB5vtLnKKRw0ic=; b=F21W/1aY0yx9NT5zEYQEZRM1oprA26SYgagN2iAPYJS6KPOQyWj09maqJhqMFMVfj6 dfHpmy+WlxZSFhSKfshNK0fgMW9aBmjYu/ZDuKnX8VcKdy07i9ZJKqzeS9zznnaqyRLh vnwUeoqxJM1GwCZ5kzGRHUKPkaQOFnC6/j35WklXnHLBVXLPNWvK5djlYfJmblSuOQU+ 9cdwF6d61o8nBSYATmNUsjF50KYeFpibbFKDq+pbuS8qnETxlGWAMGk9bWAF3ZC8AYh5 zMCSrKLvKOw+vlF51Xni0gAYnBgl59nK/FJ5MVQkAOi4tW/X2qVkKeHObsy4zfboIX9W DVjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699097455; x=1699702255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ViIC/HSzRl49SaVz7Ic3OZfsB5CjZfB5vtLnKKRw0ic=; b=cpgg+toDEj2r+I9Z6eXFFcUZUe3tgerId+ECxCEL469iOMwQJH7brvdOp3W9Ly1wDH mk/5gBIA1hdW+3EOBuXvHkNqSzKPc1d3TWUaYeRFNRRcE36U5K/qqwatGkRyCXGQnQw8 5PsyPlNPwYz6i+C//71/PmP6dv9CnCMpjr6c4nHx5Ohb0UtotQFu6A79JtrwgOTHiZPn ooiqajmjGJKZwydWF0QhmZvoNYE0sWckMUiGWm0VdTotGF4QXn2w1VxXcl+X/YRX9AGz E4A7fkE0K12HFGXCKnAtN2jzGT8jXc1v3IoeWfhxDR8EiCJLZo2a6IkOYC0Av/veZfsG gwkw== X-Gm-Message-State: AOJu0YwtyxmWeIZmA3ms9coPKtCW5YHnEKyREXlERsFRFpEOYuEC1unj IxzLJZz3PmhiwINYLsDUifyJ5Q== X-Google-Smtp-Source: AGHT+IG7+PVg2+j7nGj7tYNTi4rQ5slXe9O1zzNFrQ+IoKAC5ivvACWeQEyqrrRa0PtPlKH+b4ylJQ== X-Received: by 2002:a17:907:70b:b0:9d2:20ee:b18b with SMTP id xb11-20020a170907070b00b009d220eeb18bmr8758416ejb.42.1699097455299; Sat, 04 Nov 2023 04:30:55 -0700 (PDT) Received: from [192.168.0.153] (178235177017.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.17]) by smtp.gmail.com with ESMTPSA id s5-20020a170906454500b009c7608eb499sm1878707ejq.94.2023.11.04.04.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Nov 2023 04:30:55 -0700 (PDT) Message-ID: <26af3ecc-8b3f-4b10-b594-eae57de501cb@linaro.org> Date: Sat, 4 Nov 2023 12:30:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] iommu/arm-smmu: re-enable context caching in smmu reset operation Content-Language: en-US To: Bibek Kumar Patro , will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, dmitry.baryshkov@linaro.org, a39.skl@gmail.com, quic_saipraka@quicinc.com, quic_pkondeti@quicinc.com, quic_molvera@quicinc.com Cc: linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, qipl.kernel.upstream@quicinc.com References: <20231103215124.1095-1-quic_bibekkum@quicinc.com> <20231103215124.1095-4-quic_bibekkum@quicinc.com> From: Konrad Dybcio In-Reply-To: <20231103215124.1095-4-quic_bibekkum@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231104_043057_201079_7326C7AE X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/3/23 22:51, Bibek Kumar Patro wrote: > Context caching is re-enabled in the prefetch buffer for Qualcomm SoCs > through SoC specific reset ops, which is disabled in the default MMU-500 > reset ops, but is expected for context banks using ACTLR register to > retain the prefetch value during reset and runtime suspend. > > Signed-off-by: Bibek Kumar Patro > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 26 ++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > index 590b7c285299..f342b4778cf1 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > @@ -457,11 +457,29 @@ static int qcom_smmu_def_domain_type(struct device *dev) > return match ? IOMMU_DOMAIN_IDENTITY : 0; > } > > +#define ARM_MMU500_ACTLR_CPRE BIT(1) > + > +static int qcom_smmu500_reset(struct arm_smmu_device *smmu) > +{ > + int i; > + u32 reg; > + > + arm_mmu500_reset(smmu); > + > + for (i = 0; i < smmu->num_context_banks; ++i) { This loop deserves a comment above it like /* Re-enable context caching after reset */ Konrad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel