linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: halting the kernel does not stop the CPU cores?
Date: Thu, 27 Jul 2017 13:07:00 -0700	[thread overview]
Message-ID: <26ccb0f7-0f78-27cd-cead-ddd810f4a33e@gmail.com> (raw)
In-Reply-To: <VI1PR04MB1662099750F9EAFA0324C6538CBE0@VI1PR04MB1662.eurprd04.prod.outlook.com>

On 07/27/2017 07:38 AM, Heinz Wrobel wrote:
> Hi,
> 
> I noticed that when halting the kernel (intentionally or not), the cores effectively go into a while(1) loop and power consumption on larger devices really jumps up significantly to the point where, e.g., a ?crash? turns into ?crash and burn?.
> 
> I would assume that if a system is halted, you don?t want to dissipate more power than on a running system but go as silent as low power as reasonable.
> 
> Is there any specific reason why the cores would not go into a wfi loop like they do on idle?
> The patch to fix this seems to be easy at first glance, but is there a good reason *NOT* to do such a patch and to leave the plain while(1)?

In fact, if your platform supports CPU_HOTPLUG, I am not clear why
smp_send_stop() + ipi_send_stop() is not calling platform_cpu_kill()
which would be smp_ops.cpu_kill() but instead cpu_relax() was chosen?

The CPU is dead anyway so as you say, so it's not like there is a remote
chance to resume execution on these secondary cores?
--
Florian

  parent reply	other threads:[~2017-07-27 20:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 14:38 halting the kernel does not stop the CPU cores? Heinz Wrobel
2017-07-27 18:27 ` Baruch Siach
2017-07-27 20:07 ` Florian Fainelli [this message]
2017-07-27 22:25   ` Russell King - ARM Linux
2017-07-27 23:27     ` icenowy at aosc.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26ccb0f7-0f78-27cd-cead-ddd810f4a33e@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).