From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1440C7EE29 for ; Fri, 9 Jun 2023 09:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bu4UzhBsyvu1Ecbo2S+9Pzp2IwgKGImviwv9WL/iWio=; b=ZgDGJs/BpFY/FT RWpceJUXq0hxnpetB+o9OfQ1RHZxsHkP82Tw2aNHQseo9FpWHzQhQoBoxV4ZR0cIiXfcCjD8SHkNM ViIdHECK76NgzMv2Os5RYiFvnMBTn7mwDXXPUfl8zA6iyq4j1TLh9PsCWNaLzWVOJQBgBbLE9jy11 O3rwiVEWy0e+RxTz/KXRiZOapxDoakKuWhi7IQsTFzmeisdDKhvEUwkjHtB1Jb7oxW7pFZbCGjjr5 RJ6odo2gtXet2MmzLSDfdXBt8vyb0qQHmotjU33xGti2Nvv98FLOvc+lkKFihxeOX7TMqk0AwYVqQ EBnS3bQk+HA5U/AWfz7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7Y6J-00CMUF-1V; Fri, 09 Jun 2023 09:08:07 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7Y6G-00CMTY-2m for linux-arm-kernel@lists.infradead.org; Fri, 09 Jun 2023 09:08:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686301683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+lS4qtD2LImPdpu4Ozd1FIICWXob78VQWCuBmNpNqeU=; b=UIfhVDnh/GijU2RTxVyX7jVWGWJKifEkep086SQ7PJBGa5VCOszPVEQA1x2MVv7i+9qFWh Uds8IH2murz4aqdZi27npzTmy81QregC5Iy2pSr8La65780ySVjD/bYNfj+z0+Dq3s6QCE ZDiE0gTilVMdKXb1Ur8NRJUKAfslOoQ= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-MOHLp1SMOlGMGme1EFFVag-1; Fri, 09 Jun 2023 05:08:02 -0400 X-MC-Unique: MOHLp1SMOlGMGme1EFFVag-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-97463348446so185488166b.2 for ; Fri, 09 Jun 2023 02:08:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301681; x=1688893681; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+lS4qtD2LImPdpu4Ozd1FIICWXob78VQWCuBmNpNqeU=; b=Qcji8j4wrz9CEeVbyHEBx8XdN17el9R9gYeADTAilf2NLKSl6ZhV2M/Jtc0RMC+2ZP XWY5ArV8BZBshph/99yQVPRYmEC844LF3dab5QCP2PaxJBb0s4UyigVubuDR/1Hun7ie y3+y+uNesZC9/gZ+bVLqnNk9ctLdB6GSDnarhC6WRjAdfBVCO0hM5HDdQhTTXhuk83iY 3xb2ZRoRYfmnCdAoSb9oiRM03PS4+el8Z1Ih7/Qtck3pSr+eVefdYPeFKRkcYqe4Rojf 8poCE8SR5cJJf3KzW3BrjoBxV+cgLfVsIfaWlU9gBqGFcUYGGjVzjdltrWFJ4m5UkpdH WfoA== X-Gm-Message-State: AC+VfDy0BKxbATmmo2HTbSqGN8H3Fr+RcJ1/2ef9xD9fiHnZgGBDvtg/ HWRHrwczP1uECnglmpDpl1bjIatDqXlh4suQqCqJTOvwK9rsa50yrrOodCfgyhLUcJoVfgA3qqf /80iGUDUD90t1m1CwD2i+4sTI9PaDDFkbLgI= X-Received: by 2002:a17:907:94cb:b0:97a:e0c0:2f8f with SMTP id dn11-20020a17090794cb00b0097ae0c02f8fmr315210ejc.65.1686301681493; Fri, 09 Jun 2023 02:08:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6fk08I4RsyK9p9wcnjDRbMYLy3XBaoHlqt3xl1DLkFDODgHMHCV4XPzuR/CPTVwoW0y6Qefw== X-Received: by 2002:a17:907:94cb:b0:97a:e0c0:2f8f with SMTP id dn11-20020a17090794cb00b0097ae0c02f8fmr315171ejc.65.1686301681128; Fri, 09 Jun 2023 02:08:01 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id z8-20020a1709067e4800b00977ecf6942bsm1036209ejr.90.2023.06.09.02.07.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 02:08:00 -0700 (PDT) Message-ID: <26cf0b0a-cda5-08a9-a669-6966f9e626b1@redhat.com> Date: Fri, 9 Jun 2023 11:07:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Yu Zhao , Andrew Morton Cc: Alistair Popple , Anup Patel , Ben Gardon , Borislav Petkov , Catalin Marinas , Chao Peng , Christophe Leroy , Dave Hansen , Fabiano Rosas , Gaosheng Cui , Gavin Shan , "H. Peter Anvin" , Ingo Molnar , James Morse , "Jason A. Donenfeld" , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Masami Hiramatsu , Michael Ellerman , Michael Larabel , Mike Rapoport , Nicholas Piggin , Oliver Upton , Paul Mackerras , Peter Xu , Sean Christopherson , Steven Rostedt , Suzuki K Poulose , Thomas Gleixner , Thomas Huth , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, linux-mm@google.com References: <20230526234435.662652-1-yuzhao@google.com> From: Paolo Bonzini Subject: Re: [PATCH mm-unstable v2 00/10] mm/kvm: locklessly clear the accessed bit In-Reply-To: <20230526234435.662652-1-yuzhao@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_020804_970523_182E5ED6 X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/27/23 01:44, Yu Zhao wrote: > TLDR > ==== > This patchset adds a fast path to clear the accessed bit without > taking kvm->mmu_lock. It can significantly improve the performance of > guests when the host is under heavy memory pressure. > > ChromeOS has been using a similar approach [1] since mid 2021 and it > was proven successful on tens of millions devices. > > This v2 addressed previous requests [2] on refactoring code, removing > inaccurate/redundant texts, etc. > > [1]https://crrev.com/c/2987928 > [2]https://lore.kernel.org/r/20230217041230.2417228-1-yuzhao@google.com/ From the KVM point of view the patches look good (though I wouldn't mind if Nicholas took a look at the ppc part). Jason's comment on the MMU notifier side are promising as well. Can you send v3 with Oliver's comments addressed? Thanks, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel