From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2943C433EF for ; Sun, 13 Feb 2022 02:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=41zMp9HGpp3Nf4vOSb4tEy/ycSjKY8HfOH0ZJ0wDq5k=; b=vab1f+h0Po2Eec uzY43Xw0hvZVQwxjQPgsXSAXHuy1Fy0wG55Pi62BzBl3xMlGoluzYH1qHnauZxvmbLR33eCp8lRH9 dEb1qlnT6SXtT0fHZgJIJHYhVQsKEQs3hX7THRoglRonzDTGGf1cQDic5dtmKH1UU/vXdkU6X7s0r 0ODzAUp47KvvPPPqy4KxP9kPNQC3ZRA0K+olszZ87/whHQx+y8bl0ohJEJcx3FG8jei+SILo+NsAh 4dy0/7yvuC0FhHd4A+cHxXJoakwAOlDYtZCBDNI4enb6+7BA2JrnMSaSsL7sVy9ezmq56ogUAly3/ x9p6DRGq3iTAvC/H0cwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJ4VF-00AoAO-09; Sun, 13 Feb 2022 02:20:41 +0000 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJ4VA-00Ao9X-Mb for linux-arm-kernel@lists.infradead.org; Sun, 13 Feb 2022 02:20:38 +0000 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-73-Q-v6TvLNNIq7os3zIscGRA-1; Sun, 13 Feb 2022 02:20:29 +0000 X-MC-Unique: Q-v6TvLNNIq7os3zIscGRA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Sun, 13 Feb 2022 02:20:27 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.028; Sun, 13 Feb 2022 02:20:27 +0000 From: David Laight To: 'Kees Cook' , Ard Biesheuvel CC: Victor Erminpour , Robin Murphy , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , "ACPI Devel Maling List" , Linux ARM , Linux Kernel Mailing List , "trivial@kernel.org" Subject: RE: [PATCH v2] ACPI/IORT: Fix GCC 12 warning Thread-Topic: [PATCH v2] ACPI/IORT: Fix GCC 12 warning Thread-Index: AQHYHtiyz9LUyAjRSUu2IalWh5Ct1KyQwgtg Date: Sun, 13 Feb 2022 02:20:27 +0000 Message-ID: <26dee09f5fc8420782e4556d86c55a04@AcuMS.aculab.com> References: <1644518851-16847-1-git-send-email-victor.erminpour@oracle.com> <202202101415.43750CEE@keescook> In-Reply-To: <202202101415.43750CEE@keescook> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220212_182037_048835_26E98BF2 X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Kees Cook > Sent: 10 February 2022 23:47 ... > All that said, I think this patch could be improved. > > I'd recommend, instead, just simply: > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index f2f8f05662de..9e765d30da82 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -1671,13 +1671,14 @@ phys_addr_t __init acpi_iort_dma_get_max_cpu_address(void) > end = ACPI_ADD_PTR(struct acpi_iort_node, iort, iort->header.length); > > for (i = 0; i < iort->node_count; i++) { > + struct acpi_iort_named_component *ncomp; > + struct acpi_iort_root_complex *rc; > + phys_addr_t local_limit; > + I'd move them right to the top of the function. No point hiding the declarations in the middle. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel