From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD43DC282DD for ; Tue, 23 Apr 2019 17:54:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1B9920651 for ; Tue, 23 Apr 2019 17:54:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bvvNP87B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1B9920651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g6qennqIghloBO08TJ0npLWfhaUelU08t+VmxUuJv3w=; b=bvvNP87BifoN1N pEcvirJ8L2H6K9j6Je9wmENgR+z5itVmIiuVB3gvXE6R5DmPpdn9WHfboFw8r024RA+JmDMcqTVbt QITwfNi+wRjpTbbL20nzX8fC7UejQrajQ6r2/tFbdhD7COBbxlQcuvYByFHUYNaTbY1Bgpu8o/ZrY LBPuNnR4Dpl2nk0EeJjPzT/3B99AN4FDfhaslHrneQSb+Go38qACLtaw/Q2CW4Xf6Teq5zDfqEWI4 Zr+n9b1jo+u/s1LuA8l8bquTOtCeOijCcgsxtFXWGv9znn7Ifa8w2qOZSkrODwf/s97Gajzgf7VNK LwoPg/cmg+7OYL2Ss2tw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIzcw-0001Hs-Lt; Tue, 23 Apr 2019 17:54:42 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIzct-0001H6-An; Tue, 23 Apr 2019 17:54:40 +0000 Received: from p57b772a1.dip0.t-ipconnect.de ([87.183.114.161] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hIzco-0003ub-LG; Tue, 23 Apr 2019 19:54:34 +0200 From: Heiko Stuebner To: Wen Yang Subject: Re: [PATCH 3/4] ARM: rockchip: fix a leaked reference by adding missing of_node_put Date: Tue, 23 Apr 2019 19:54:34 +0200 Message-ID: <2700593.YbihCcEB6N@phil> In-Reply-To: <1551785577-45896-3-git-send-email-wen.yang99@zte.com.cn> References: <1551785577-45896-1-git-send-email-wen.yang99@zte.com.cn> <1551785577-45896-3-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_105439_519971_9596EDFB X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 5. M=E4rz 2019, 12:32:56 CEST schrieb Wen Yang: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > = > Detected by coccinelle with the following warnings: > ./arch/arm/mach-rockchip/platsmp.c:250:2-8: ERROR: missing of_node_put; a= cquired a node pointer with refcount incremented on line 241, but without a= corresponding object release within this function. > ./arch/arm/mach-rockchip/platsmp.c:260:2-8: ERROR: missing of_node_put; a= cquired a node pointer with refcount incremented on line 241, but without a= corresponding object release within this function. > ./arch/arm/mach-rockchip/platsmp.c:263:1-7: ERROR: missing of_node_put; a= cquired a node pointer with refcount incremented on line 241, but without a= corresponding object release within this function. > = > Signed-off-by: Wen Yang > Cc: Russell King > Cc: Heiko Stuebner > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-kernel@vger.kernel.org applied for 5.2 after adapting the patch subject a little bit Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel